ci: add required status checks for terraform-provider-rhcs Tide

[amandahla]

Summary

Restore Tide merge automation for terraform-redhat/terraform-provider-rhcs by listing all non-optional presubmit prow jobs in required_status_checks.contexts.

Type of change

ci

Related

None

Changes

• Add ci/prow/images, ci/prow/e2e-images, ci/prow/e2e-presubmits-images, and the four critical-high e2e presubmits to terraform-provider-rhcs/_prowconfig.yaml branch-protection contexts.
• Leave optional e2e presubmits out of required checks so they do not block merge.

Breaking changes

No.

Testing / validation

• Verified required contexts match non-optional presubmit jobs in terraform-redhat-terraform-provider-rhcs-main-presubmits.yaml.
• Pattern aligned with terraform-rhcs-rosa-hcp and terraform-rhcs-rosa-classic _prowconfig.yaml.

Made with Cursor

Summary by CodeRabbit

This PR updates the CI branch-protection settings for terraform-redhat/terraform-provider-rhcs so Tide now waits on the full set of non-optional presubmit jobs before allowing merges. In practice, this restores merge automation by marking the image, e2e image, and required high-priority e2e presubmit checks as mandatory while keeping optional e2e jobs non-blocking. The required checks were aligned with the repo’s presubmit job definitions and with the pattern used by similar Terraform RHCS repositories.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 48d9b18f-9eb5-4228-a14b-a349c6edb854

📥 Commits

Reviewing files that changed from the base of the PR and between 436ce01 and 02b2686.

📒 Files selected for processing (1)

• core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/_prowconfig.yaml

---

Walkthrough

The PR updates branch protection for terraform-redhat/terraform-provider-rhcs on main by adding several required CI status check contexts.

Changes

Branch protection update

Layer / File(s)	Summary
Required status checks core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/_prowconfig.yaml	The main branch required_status_checks.contexts list adds image-build, e2e, and ROSA/STJ-related CI contexts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• openshift/release#80705: Updates _prowconfig.yaml branch protection to require additional Prow CI status checks.
• openshift/release#80765: Adds required branch-protection contexts tied to new Prow presubmit checks.
• openshift/release#81052: Modifies required_status_checks.contexts in _prowconfig.yaml to gate merges on additional CI contexts.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

• olucasfreitas
• BraeTroutman

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the change to add required CI status checks for terraform-provider-rhcs Tide.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The PR only edits a prow YAML config; no Ginkgo test files or titles were added or modified, so the naming rule doesn’t apply.
Test Structure And Quality	✅ Passed	PASS: This PR only updates prow branch-protection YAML; no Ginkgo test files or test logic changed.
Microshift Test Compatibility	✅ Passed	Only branch-protection YAML changed; no new Ginkgo e2e tests or test bodies were added, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only edits _prowconfig.yaml branch-protection contexts; no Ginkgo e2e tests were added or modified, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a prow branch-protection YAML was changed; no manifests, controllers, or scheduling logic were modified.
Ote Binary Stdout Contract	✅ Passed	PR only changes a Prow YAML config; no process-level binary code or stdout writes were added in the touched path.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only edits branch-protection YAML; no new Ginkgo specs or network-dependent test code were added.
No-Weak-Crypto	✅ Passed	Changed file is CI YAML only; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret/token comparisons were present.
Container-Privileges	✅ Passed	The PR only edits a Prow branch-protection YAML; no privileged/root/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs	✅ Passed	Change only updates branch-protection required_status_checks contexts; no code/logging or sensitive-data strings are introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@amandahla: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[openshift-ci]

@amandahla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jerichokeyne]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amandahla, jerichokeyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/OWNERS [amandahla,jerichokeyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@amandahla: Updated the following 2 configmaps:

• config configmap in namespace ci at cluster core-ci using the following files:
  • key core-services-prow-02_config-terraform-redhat-terraform-provider-rhcs-_prowconfig.yaml using file core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/_prowconfig.yaml
• config configmap in namespace ci at cluster app.ci using the following files:
  • key core-services-prow-02_config-terraform-redhat-terraform-provider-rhcs-_prowconfig.yaml using file core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/_prowconfig.yaml

Details

In response to this:

Summary

Restore Tide merge automation for terraform-redhat/terraform-provider-rhcs by listing all non-optional presubmit prow jobs in required_status_checks.contexts.

Type of change

ci

Related

None

Changes

• Add ci/prow/images, ci/prow/e2e-images, ci/prow/e2e-presubmits-images, and the four critical-high e2e presubmits to terraform-provider-rhcs/_prowconfig.yaml branch-protection contexts.
• Leave optional e2e presubmits out of required checks so they do not block merge.

Breaking changes

No.

Testing / validation

• Verified required contexts match non-optional presubmit jobs in terraform-redhat-terraform-provider-rhcs-main-presubmits.yaml.
• Pattern aligned with terraform-rhcs-rosa-hcp and terraform-rhcs-rosa-classic _prowconfig.yaml.

Made with Cursor

Summary by CodeRabbit

This PR updates the CI branch-protection settings for terraform-redhat/terraform-provider-rhcs so Tide now waits on the full set of non-optional presubmit jobs before allowing merges. In practice, this restores merge automation by marking the image, e2e image, and required high-priority e2e presubmit checks as mandatory while keeping optional e2e jobs non-blocking. The required checks were aligned with the repo’s presubmit job definitions and with the pattern used by similar Terraform RHCS repositories.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.