Skip to content

ROSA-745: require full prow checks for rbac-permissions-operator #80705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 22, 2026
Merged

ROSA-745: require full prow checks for rbac-permissions-operator #80705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core-services/prow/02_config/openshift/rbac-permissions-operator/_prowconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@ branch-protection:
required_status_checks:
contexts:
- Konflux kflux-prd-rh03 / rbac-permissions-operator-on-pull-request
- ci/prow/coverage
- ci/prow/e2e-binary-build-success
- ci/prow/images
- ci/prow/lint
- ci/prow/test
- ci/prow/validate
Comment on lines +12 to +17

@feichashao feichashao Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These jobs are not always run. always_run: false.

release/ci-operator/jobs/openshift/rbac-permissions-operator/openshift-rbac-permissions-operator-master-presubmits.yaml

Line 200 in a9c97b9

always_run: false

If we are mandating these tests to pass, for those PRs which skip these tests, they won't be able to merge as those tests won't run. (that's my understanding, please correct me).

I understand the intention is to let the auto merge works, while preventing it from merging the failed test PRs.

If we need to urgent fix this, possible ideas:

(1) We can set those jobs to always_run: true. It could be a little bit waste of compute resources but it doesn't hurt to test all PRs.

(2) Let the auto merge to add the lgtm/approve label, so it can follow the tide process which needs all required tests to pass before it merges.

@MitaliBhalla MitaliBhalla Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — you're right that lint, test, coverage, validate, and e2e-binary-build-success are always_run: false in ci-operator today.

The motivation is MintMaker #367: it merged via GitHub auto-merge while those prow jobs were red. GitHub only enforces checks listed in required_status_checks.contexts; Tide required-if-present-contexts does not block platform auto-merge.

#79945 only required Konflux + ci/prow/images, so this follow-up adds the full DPP prow set explicitly so a failed validate/lint/etc. blocks auto-merge when those jobs run.

On the skip edge case: if a PR never triggers a conditional mandatory job, GitHub may show the context as pending/expected. Mitigations if that becomes painful:

  1. Flip the DPP prow presubmits to always_run: true for rbac-permissions-operator in a follow-up release PR (more compute, unambiguous gating).
  2. Keep Tide + lgtm/approved as the merge path for PRs where auto-merge is not appropriate.

Happy to do (1) in this PR or a fast follow-up if you prefer that over the current explicit-context approach.

@feichashao feichashao Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MitaliBhalla Thanks for checking!

Let's merge this one first, so you can test and validate. Could you create a follow-up PR or card to flip always_run? I want to keep that on track.

tide:
queries:
- labels:
Expand Down