prow: configure Tide and CodeRabbit context for coderabbit repos#80439
Conversation
|
/hold |
WalkthroughProw tide context requirements and per-repository Prow configs are added so coderabbit repos under openshift, openshift-eng, and openshift-online require the CodeRabbit status; each repo gets OWNERS, pluginconfig, and prowconfig entries. ChangesCodeRabbit Configuration Enablement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2952a31 to
7b1e1f9
Compare
Add Tide merge queries and CodeRabbit as a required context for openshift/coderabbit, openshift-eng/coderabbit, and openshift-online/coderabbit. Assisted-by: Claude:claude-opus-4-6
7b1e1f9 to
b0d441c
Compare
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core-services/prow/02_config/openshift-eng/coderabbit/_pluginconfig.yaml (1)
1-20: ⚡ Quick winConsider adding
lgtmconfiguration for GitHub review integration.Both
openshift-eng/coderabbit/_pluginconfig.yamlandopenshift-online/coderabbit/_pluginconfig.yamlenable thelgtmplugin but lack thelgtmconfiguration section. Addingreview_acts_as_lgtm: truewould allow GitHub's native review approval to automatically apply the LGTM label, improving developer experience by removing the need for manual/lgtmcomments.✨ Suggested enhancement
Add this section after the
approveconfiguration in both files:require_self_approval: false +lgtm: +- repos: + - openshift-eng/coderabbit # or openshift-online/coderabbit for the other file + review_acts_as_lgtm: true external_plugins:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core-services/prow/02_config/openshift-eng/coderabbit/_pluginconfig.yaml` around lines 1 - 20, The plugin config enables the lgtm plugin but lacks its configuration; add an lgtm section (sibling to the existing approve block) with review_acts_as_lgtm: true so GitHub review approvals map to the LGTM label; update the YAML to include a top-level lgtm: block containing review_acts_as_lgtm: true to enable this behavior for the lgtm plugin.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@core-services/prow/02_config/openshift-eng/coderabbit/_pluginconfig.yaml`:
- Around line 1-20: The plugin config enables the lgtm plugin but lacks its
configuration; add an lgtm section (sibling to the existing approve block) with
review_acts_as_lgtm: true so GitHub review approvals map to the LGTM label;
update the YAML to include a top-level lgtm: block containing
review_acts_as_lgtm: true to enable this behavior for the lgtm plugin.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 43c37246-9b14-4a86-a46d-176a0f4023b1
📒 Files selected for processing (7)
core-services/prow/02_config/_config.yamlcore-services/prow/02_config/openshift-eng/coderabbit/OWNERScore-services/prow/02_config/openshift-eng/coderabbit/_pluginconfig.yamlcore-services/prow/02_config/openshift-eng/coderabbit/_prowconfig.yamlcore-services/prow/02_config/openshift-online/coderabbit/OWNERScore-services/prow/02_config/openshift-online/coderabbit/_pluginconfig.yamlcore-services/prow/02_config/openshift-online/coderabbit/_prowconfig.yaml
✅ Files skipped from review due to trivial changes (1)
- core-services/prow/02_config/openshift-online/coderabbit/OWNERS
🚧 Files skipped from review as they are similar to previous changes (4)
- core-services/prow/02_config/openshift-eng/coderabbit/_prowconfig.yaml
- core-services/prow/02_config/openshift-eng/coderabbit/OWNERS
- core-services/prow/02_config/_config.yaml
- core-services/prow/02_config/openshift-online/coderabbit/_prowconfig.yaml
|
@cblecker: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, hector-vido The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cblecker: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…nshift#80439) Add Tide merge queries and CodeRabbit as a required context for openshift/coderabbit, openshift-eng/coderabbit, and openshift-online/coderabbit. Assisted-by: Claude:claude-opus-4-6
…nshift#80439) Add Tide merge queries and CodeRabbit as a required context for openshift/coderabbit, openshift-eng/coderabbit, and openshift-online/coderabbit. Assisted-by: Claude:claude-opus-4-6
Summary
required-contextsin Tide context options foropenshift/coderabbit,openshift-eng/coderabbit, andopenshift-online/coderabbitopenshift-eng/coderabbitandopenshift-online/coderabbit(openshift/coderabbitalready had one)Test plan
make checkconfigpassesSummary by CodeRabbit
This PR updates OpenShift Prow configuration so Tide requires the CodeRabbit status check and adds Tide merge queries + plugin scaffolding for the CodeRabbit repositories under three OpenShift orgs, affecting how PR merges are gated for those repos.
Practical changes:
Tide required-contexts:
Per-repo Tide merge queries:
Per-repo plugin configs:
Repository scaffolding / OWNERS:
Tests / post-merge verification:
Status: