Skip to content

prow: configure Tide and CodeRabbit context for coderabbit repos#80439

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
cblecker:coderabbit-tide-config
Jun 11, 2026
Merged

prow: configure Tide and CodeRabbit context for coderabbit repos#80439
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
cblecker:coderabbit-tide-config

Conversation

@cblecker

@cblecker cblecker commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Add "CodeRabbit" as a required-contexts in Tide context options for openshift/coderabbit, openshift-eng/coderabbit, and openshift-online/coderabbit
  • Add Tide merge queries for openshift-eng/coderabbit and openshift-online/coderabbit (openshift/coderabbit already had one)
  • Add placeholder OWNERS files for the two new repo config directories

Test plan

  • make checkconfig passes
  • Verify Tide picks up the new queries after merge
  • Verify CodeRabbit status check is required before merge on all three repos

Summary by CodeRabbit

This PR updates OpenShift Prow configuration so Tide requires the CodeRabbit status check and adds Tide merge queries + plugin scaffolding for the CodeRabbit repositories under three OpenShift orgs, affecting how PR merges are gated for those repos.

Practical changes:

  • Tide required-contexts:

    • core-services/prow/02_config/_config.yaml now marks the CodeRabbit status check as required for:
      • openshift/coderabbit
      • openshift-eng/coderabbit
      • openshift-online/coderabbit
    • Effect: Tide will block merges in those repos until the CodeRabbit status check passes.
  • Per-repo Tide merge queries:

    • core-services/prow/02_config/openshift-eng/coderabbit/_prowconfig.yaml — adds a Tide query for openshift-eng/coderabbit requiring labels: approved + lgtm and treating do-not-merge/* and needs-rebase as blocking.
    • core-services/prow/02_config/openshift-online/coderabbit/_prowconfig.yaml — same query scoped to openshift-online/coderabbit.
    • Note: openshift/coderabbit already had a Tide query prior to this change.
  • Per-repo plugin configs:

    • Added _pluginconfig.yaml for openshift-eng/coderabbit and openshift-online/coderabbit enabling approve (lgtm_acts_as_approve: true, require_self_approval: false), wiring an external needs-rebase plugin endpoint, and enabling built-in plugins: approve, hold, lgtm, verify-owners, wip.
  • Repository scaffolding / OWNERS:

    • Added placeholder OWNERS for openshift-eng/coderabbit and openshift-online/coderabbit listing cblecker as approver and reviewer.

Tests / post-merge verification:

  • Run make checkconfig.
  • Confirm Tide picks up the new queries after merge.
  • Confirm the CodeRabbit status check is required and blocks merges on all three repos.

Status:

  • PR is held for review ("/hold for review").

@cblecker

Copy link
Copy Markdown
Member Author

/hold
for review

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Prow tide context requirements and per-repository Prow configs are added so coderabbit repos under openshift, openshift-eng, and openshift-online require the CodeRabbit status; each repo gets OWNERS, pluginconfig, and prowconfig entries.

Changes

CodeRabbit Configuration Enablement

Layer / File(s) Summary
Central Tide Context Configuration
core-services/prow/02_config/_config.yaml
Main tide configuration is updated to require CodeRabbit status context for coderabbit repositories under openshift, openshift-eng, and openshift-online.
OpenShift-eng Repository Setup
core-services/prow/02_config/openshift-eng/coderabbit/OWNERS, core-services/prow/02_config/openshift-eng/coderabbit/_pluginconfig.yaml, core-services/prow/02_config/openshift-eng/coderabbit/_prowconfig.yaml
openshift-eng/coderabbit repository designates cblecker as approver and reviewer, and defines plugin and tide settings: approve behavior, needs-rebase external plugin endpoint/events, enabled plugins list, and a tide query requiring approved and lgtm with specified missingLabels.
OpenShift-online Repository Setup
core-services/prow/02_config/openshift-online/coderabbit/OWNERS, core-services/prow/02_config/openshift-online/coderabbit/_pluginconfig.yaml, core-services/prow/02_config/openshift-online/coderabbit/_prowconfig.yaml
openshift-online/coderabbit repository designates cblecker as approver and reviewer, and defines plugin and tide settings mirroring the openshift-eng configuration (approve behavior, needs-rebase external plugin, enabled plugins, and tide query with approved/lgtm and missingLabels).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

lgtm

Suggested reviewers

  • smg247
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: configuring Tide and CodeRabbit context for the coderabbit repositories across multiple orgs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR #80439 changes only YAML/OWNERS config; searched modified files for Ginkgo It/Describe/Context/When—no matches, so no test titles were introduced or renamed.
Test Structure And Quality ✅ Passed PR #80439 only changes Prow YAML/OWNERS files (13 additions, 0 deletions); no Ginkgo/Go test code was modified, so quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed PR #80439 changes only prow Tide/OWNERS YAML files; no Ginkgo/e2e Go test files (_test.go) are added or modified, so no MicroShift-compatibility issues apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR #80439 only changes prow Tide/OWNERS YAML files (5 paths); no Ginkgo e2e (_test.go/e2e) tests were added, so no SNO assumptions to flag.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only Prow CI/CD configuration (Tide, plugins, OWNERS files), not deployment manifests, operators, or workload scheduling constraints. Check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR #80439 changes only 5 prow YAML/OWNERS files (no Go/OTE binary code), so it cannot introduce stdout contract violations in OTE binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds only Prow configuration files (YAML and OWNERS), not Ginkgo e2e tests. The IPv6/disconnected network check applies only to new test code.
No-Weak-Crypto ✅ Passed PR changes are Tide/OWNERS YAML for CodeRabbit contexts; searches of the PR diff for MD5/SHA1/DES/RC4/3DES/Blowfish/ECB (and ConstantTime/crypto compares) found no matches.
Container-Privileges ✅ Passed PR modifies only Prow configuration and OWNERS files (no container/K8s manifests), so container-privileges check is not applicable.
No-Sensitive-Data-In-Logs ✅ Passed PR commit diff changes only Prow/Tide YAML + OWNERS (CodeRabbit required-contexts, tide query labels, approver cblecker). No tokens/passwords/PII/hostnames or logging strings added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jmguzik and pruan-rht June 11, 2026 19:40
@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 11, 2026
@cblecker cblecker force-pushed the coderabbit-tide-config branch from 2952a31 to 7b1e1f9 Compare June 11, 2026 19:49
Add Tide merge queries and CodeRabbit as a required context for
openshift/coderabbit, openshift-eng/coderabbit, and
openshift-online/coderabbit.

Assisted-by: Claude:claude-opus-4-6
@cblecker cblecker force-pushed the coderabbit-tide-config branch from 7b1e1f9 to b0d441c Compare June 11, 2026 21:19
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@cblecker: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
core-services/prow/02_config/openshift-eng/coderabbit/_pluginconfig.yaml (1)

1-20: ⚡ Quick win

Consider adding lgtm configuration for GitHub review integration.

Both openshift-eng/coderabbit/_pluginconfig.yaml and openshift-online/coderabbit/_pluginconfig.yaml enable the lgtm plugin but lack the lgtm configuration section. Adding review_acts_as_lgtm: true would allow GitHub's native review approval to automatically apply the LGTM label, improving developer experience by removing the need for manual /lgtm comments.

✨ Suggested enhancement

Add this section after the approve configuration in both files:

  require_self_approval: false
+lgtm:
+- repos:
+  - openshift-eng/coderabbit  # or openshift-online/coderabbit for the other file
+  review_acts_as_lgtm: true
external_plugins:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core-services/prow/02_config/openshift-eng/coderabbit/_pluginconfig.yaml`
around lines 1 - 20, The plugin config enables the lgtm plugin but lacks its
configuration; add an lgtm section (sibling to the existing approve block) with
review_acts_as_lgtm: true so GitHub review approvals map to the LGTM label;
update the YAML to include a top-level lgtm: block containing
review_acts_as_lgtm: true to enable this behavior for the lgtm plugin.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@core-services/prow/02_config/openshift-eng/coderabbit/_pluginconfig.yaml`:
- Around line 1-20: The plugin config enables the lgtm plugin but lacks its
configuration; add an lgtm section (sibling to the existing approve block) with
review_acts_as_lgtm: true so GitHub review approvals map to the LGTM label;
update the YAML to include a top-level lgtm: block containing
review_acts_as_lgtm: true to enable this behavior for the lgtm plugin.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 43c37246-9b14-4a86-a46d-176a0f4023b1

📥 Commits

Reviewing files that changed from the base of the PR and between 7b1e1f9 and b0d441c.

📒 Files selected for processing (7)
  • core-services/prow/02_config/_config.yaml
  • core-services/prow/02_config/openshift-eng/coderabbit/OWNERS
  • core-services/prow/02_config/openshift-eng/coderabbit/_pluginconfig.yaml
  • core-services/prow/02_config/openshift-eng/coderabbit/_prowconfig.yaml
  • core-services/prow/02_config/openshift-online/coderabbit/OWNERS
  • core-services/prow/02_config/openshift-online/coderabbit/_pluginconfig.yaml
  • core-services/prow/02_config/openshift-online/coderabbit/_prowconfig.yaml
✅ Files skipped from review due to trivial changes (1)
  • core-services/prow/02_config/openshift-online/coderabbit/OWNERS
🚧 Files skipped from review as they are similar to previous changes (4)
  • core-services/prow/02_config/openshift-eng/coderabbit/_prowconfig.yaml
  • core-services/prow/02_config/openshift-eng/coderabbit/OWNERS
  • core-services/prow/02_config/_config.yaml
  • core-services/prow/02_config/openshift-online/coderabbit/_prowconfig.yaml

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cblecker

Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2026
@hector-vido

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2026
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, hector-vido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 2c2bff8 into openshift:main Jun 11, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@cblecker: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
    • key core-services-prow-02_config-openshift-eng-coderabbit-_prowconfig.yaml using file core-services/prow/02_config/openshift-eng/coderabbit/_prowconfig.yaml
    • key core-services-prow-02_config-openshift-online-coderabbit-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/coderabbit/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
    • key core-services-prow-02_config-openshift-eng-coderabbit-_prowconfig.yaml using file core-services/prow/02_config/openshift-eng/coderabbit/_prowconfig.yaml
    • key core-services-prow-02_config-openshift-online-coderabbit-_prowconfig.yaml using file core-services/prow/02_config/openshift-online/coderabbit/_prowconfig.yaml
Details

In response to this:

Summary

  • Add "CodeRabbit" as a required-contexts in Tide context options for openshift/coderabbit, openshift-eng/coderabbit, and openshift-online/coderabbit
  • Add Tide merge queries for openshift-eng/coderabbit and openshift-online/coderabbit (openshift/coderabbit already had one)
  • Add placeholder OWNERS files for the two new repo config directories

Test plan

  • make checkconfig passes
  • Verify Tide picks up the new queries after merge
  • Verify CodeRabbit status check is required before merge on all three repos

Summary by CodeRabbit

This PR updates OpenShift Prow configuration so Tide requires the CodeRabbit status check and adds Tide merge queries + plugin scaffolding for the CodeRabbit repositories under three OpenShift orgs, affecting how PR merges are gated for those repos.

Practical changes:

  • Tide required-contexts:

  • core-services/prow/02_config/_config.yaml now marks the CodeRabbit status check as required for:

    • openshift/coderabbit
    • openshift-eng/coderabbit
    • openshift-online/coderabbit
  • Effect: Tide will block merges in those repos until the CodeRabbit status check passes.

  • Per-repo Tide merge queries:

  • core-services/prow/02_config/openshift-eng/coderabbit/_prowconfig.yaml — adds a Tide query for openshift-eng/coderabbit requiring labels: approved + lgtm and treating do-not-merge/* and needs-rebase as blocking.

  • core-services/prow/02_config/openshift-online/coderabbit/_prowconfig.yaml — same query scoped to openshift-online/coderabbit.

  • Note: openshift/coderabbit already had a Tide query prior to this change.

  • Per-repo plugin configs:

  • Added _pluginconfig.yaml for openshift-eng/coderabbit and openshift-online/coderabbit enabling approve (lgtm_acts_as_approve: true, require_self_approval: false), wiring an external needs-rebase plugin endpoint, and enabling built-in plugins: approve, hold, lgtm, verify-owners, wip.

  • Repository scaffolding / OWNERS:

  • Added placeholder OWNERS for openshift-eng/coderabbit and openshift-online/coderabbit listing cblecker as approver and reviewer.

Tests / post-merge verification:

  • Run make checkconfig.
  • Confirm Tide picks up the new queries after merge.
  • Confirm the CodeRabbit status check is required and blocks merges on all three repos.

Status:

  • PR is held for review ("/hold for review").

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cblecker cblecker deleted the coderabbit-tide-config branch June 11, 2026 21:36
kasturinarra pushed a commit to kasturinarra/release that referenced this pull request Jun 15, 2026
…nshift#80439)

Add Tide merge queries and CodeRabbit as a required context for
openshift/coderabbit, openshift-eng/coderabbit, and
openshift-online/coderabbit.

Assisted-by: Claude:claude-opus-4-6
krisnababu pushed a commit to krisnababu/release that referenced this pull request Jun 29, 2026
…nshift#80439)

Add Tide merge queries and CodeRabbit as a required context for
openshift/coderabbit, openshift-eng/coderabbit, and
openshift-online/coderabbit.

Assisted-by: Claude:claude-opus-4-6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants