ROSA-745: branch-protection for addon-operator (Konflux + mandatory prow)

[MitaliBhalla]

Summary

ROSA-745 branch-protection for FedRAMP addon-operator (main).

Konflux + mandatory prow (7 contexts). DPP: repo settings only.

Test plan

• After merge, spot-check required Konflux + prow on a dependency PR

Summary by CodeRabbit

This PR establishes branch protection for the openshift/addon-operator repository's main branch as part of the ROSA-745 FedRAMP compliance initiative. The change adds a Prow configuration file that enforces required status checks before code can be merged.

What's protected:
The main branch of addon-operator now requires the following checks to pass before pull requests can merge:

• Konflux build check: addon-operator-on-pull-request
• Prow presubmit checks: coverage, images, lint, precommit-check, and unit

Practical impact:
Any PR to the addon-operator repository targeting the main branch must now pass both the Konflux build verification and all five mandatory Prow presubmit jobs before it can be merged. This ensures code quality and compliance requirements are met through both build and test infrastructure.

The configuration is limited to branch-protection rules and tide query settings, with no changes to the job definitions themselves.

[openshift-ci-robot]

@MitaliBhalla: This pull request references ROSA-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the initiative to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

ROSA-745: require Konflux on-pull-request for FedRAMP repo addon-operator (main).

Test plan

• After merge, branch-protector reconciles (~6h)
• Spot-check one PR: Konflux kflux-prd-rh03 / addon-operator-on-pull-request required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ec044b2b-c501-4126-b3ff-135c704b562f

📥 Commits

Reviewing files that changed from the base of the PR and between e5ea8ae and 30602b8.

📒 Files selected for processing (1)

• core-services/prow/02_config/openshift/addon-operator/_prowconfig.yaml

---

Walkthrough

Adds a branch-protection section to the Prow config for openshift/addon-operator, protecting the main branch and requiring a set of status-check contexts (Konflux and multiple ci/prow/* checks).

Changes

Branch Protection for addon-operator

Layer / File(s)	Summary
Branch protection configuration core-services/prow/02_config/openshift/addon-operator/_prowconfig.yaml	Adds a branch-protection block protecting main and listing required-status-checks: Konflux kflux-prd-rh03 / addon-operator-on-pull-request plus ci/prow/coverage, ci/prow/images, ci/prow/lint, ci/prow/precommit-check, and ci/prow/unit.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• clcollins
• joshbranham

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically references ROSA-745 and accurately describes the main change: adding branch-protection configuration for addon-operator with both Konflux and mandatory Prow checks enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only Prow configuration YAML (branch-protection and tide settings), not Ginkgo test files. Check for stable test names is not applicable.
Test Structure And Quality	✅ Passed	PR only modifies Prow CI configuration YAML file, not Ginkgo test code. Check for test structure and quality is not applicable to configuration-only changes.
Microshift Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. The PR only modifies a Prow CI configuration YAML file for branch-protection and tide settings. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR adds only Prow branch-protection and tide configuration in YAML format. No Ginkgo e2e tests are added, so the SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only Prow CI/CD configuration for branch protection and merge automation, not deployment manifests, operator code, or controllers—check not applicable.
Ote Binary Stdout Contract	✅ Passed	PR contains only YAML configuration changes to Prow settings. OTE Binary Stdout Contract check is inapplicable to configuration-only changes with no test code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests; it only modifies Prow branch-protection and tide YAML configuration for the addon-operator repository. Check is not applicable.
No-Weak-Crypto	✅ Passed	PR modifies only YAML CI configuration file with no cryptographic code, implementations, or weak crypto algorithm usage present.
Container-Privileges	✅ Passed	PR modifies a Prow CI/CD config file with branch-protection and tide settings, not a container/K8s manifest. No privileged specs found.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds only YAML configuration for Prow branch protection and tide settings. No logging statements or sensitive data (passwords, tokens, API keys, PII, etc.) are present in the file.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

@MitaliBhalla: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

[MitaliBhalla]

Branch protection layout (ROSA-745)

Supplemental _prowconfig.yaml only allows branch-protection and tide.queries (not tide.context_options).

Layer	What is required
branch-protection	Konflux *-on-pull-request + mandatory prow that are always-run on main (ci-index, coverage, images, lint, precommit-check, unit)
tide (_config.yaml)	No extra required-if-present-contexts (all mandatory prow presubmits are always-run)

Dependency PRs must pass prow/Konflux when those jobs run.

[pheckenlWork]

The FedRAMP team has looked at this PR, and we don't have any concerns.

[erdii]

This is not needed anymore since addon-operator is deployed via package-operator packages.

[MitaliBhalla]

Thanks @erdii — dropped ci/prow/ci-index-addon-operator-bundle from required contexts for addon-operator in 30602b8. Kept Konflux addon-operator-on-pull-request plus coverage/images/lint/precommit-check/unit.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@MitaliBhalla: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MitaliBhalla, psalajova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/prow/02_config/openshift/addon-operator/OWNERS [psalajova]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@MitaliBhalla: Updated the following 2 configmaps:

• config configmap in namespace ci at cluster app.ci using the following files:
  • key core-services-prow-02_config-openshift-addon-operator-_prowconfig.yaml using file core-services/prow/02_config/openshift/addon-operator/_prowconfig.yaml
• config configmap in namespace ci at cluster core-ci using the following files:
  • key core-services-prow-02_config-openshift-addon-operator-_prowconfig.yaml using file core-services/prow/02_config/openshift/addon-operator/_prowconfig.yaml

Details

In response to this:

Summary

ROSA-745 branch-protection for FedRAMP addon-operator (main).

Konflux + mandatory prow (7 contexts). DPP: repo settings only.

Test plan

• After merge, spot-check required Konflux + prow on a dependency PR

Summary by CodeRabbit

This PR establishes branch protection for the openshift/addon-operator repository's main branch as part of the ROSA-745 FedRAMP compliance initiative. The change adds a Prow configuration file that enforces required status checks before code can be merged.

What's protected:
The main branch of addon-operator now requires the following checks to pass before pull requests can merge:

• Konflux build check: addon-operator-on-pull-request
• Prow presubmit checks: coverage, images, lint, precommit-check, and unit

Practical impact:
Any PR to the addon-operator repository targeting the main branch must now pass both the Konflux build verification and all five mandatory Prow presubmit jobs before it can be merged. This ensures code quality and compliance requirements are met through both build and test infrastructure.

The configuration is limited to branch-protection rules and tide query settings, with no changes to the job definitions themselves.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.