Skip to content

Disabling coderabbit for prowjob-dispatcher jobs#78294

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
hector-vido:removing-coderabbit-dispatcher
Apr 24, 2026
Merged

Disabling coderabbit for prowjob-dispatcher jobs#78294
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
hector-vido:removing-coderabbit-dispatcher

Conversation

@hector-vido

@hector-vido hector-vido commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

This will disable coderabbit for dispatcher, there is no benefit analyzing something we already know.

Depends on openshift/ci-tools#5131

Summary by CodeRabbit

  • Chores
    • CI automation for periodically-generated pull requests now includes the "@coderabbitai ignore" directive in the PR body.

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2026
@hector-vido

Copy link
Copy Markdown
Contributor Author

/hold

@coderabbitai

coderabbitai Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ba8fb59a-ed03-4142-8f2c-d9b96715c02c

📥 Commits

Reviewing files that changed from the base of the PR and between 9afc78b and ce20ccc.

📒 Files selected for processing (1)
  • ci-operator/jobs/infra-periodics.yaml

Walkthrough

The periodic-auto-prow-job-dispatcher job in ci-operator/jobs/infra-periodics.yaml now passes a --pr-body=@coderabbitai ignore flag to /usr/bin/prow-job-dispatcher, causing created PR bodies to include @coderabbitai ignore.

Changes

Cohort / File(s) Summary
CI Configuration
ci-operator/jobs/infra-periodics.yaml
Added --pr-body=@coderabbitai ignore to the prow-job-dispatcher invocation to include @coderabbitai ignore in generated PR bodies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ❓ Inconclusive Unable to access the actual PR files or git history needed to analyze test changes and determine IPv4/connectivity issues. Provide the PR diff output, specific file paths being modified, or a link to the pull request for analysis.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Disabling coderabbit for prowjob-dispatcher jobs' directly and clearly describes the main change: adding a flag to disable coderabbit analysis for dispatcher jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request modifies only CI/CD configuration in YAML format without any Ginkgo test code, making the test name stability check inapplicable.
Test Structure And Quality ✅ Passed This PR modifies only a YAML CI/CD configuration file and does not contain any Ginkgo test code changes, making the test structure quality check not applicable.
Microshift Test Compatibility ✅ Passed This PR modifies only Prow CI configuration without adding Ginkgo e2e tests, making the MicroShift Test Compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies CI configuration in infra-periodics.yaml; no Ginkgo e2e test files or test code present.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI/CD configuration file with no scheduling constraints introduced. Not applicable to topology-aware scheduling check.
Ote Binary Stdout Contract ✅ Passed This pull request modifies only YAML configuration in ci-operator/jobs/infra-periodics.yaml, adding a flag to prow-job-dispatcher. No OTE binary code is present or modified.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2026
@openshift-ci openshift-ci Bot requested review from Prucek and deepsm007 April 24, 2026 03:49
@hector-vido hector-vido changed the title [WIP] Disabling coderabbit for prowjob-dispatcher jobs Disabling coderabbit for prowjob-dispatcher jobs Apr 24, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 24, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ci-operator/jobs/infra-periodics.yaml`:
- Line 1000: The `--pr-body="@coderabbitai ignore"` arg is including literal
quote characters in the PR body; locate the args entry with
`--pr-body="@coderabbitai ignore"` and remove the surrounding quotes so it reads
`--pr-body=@coderabbitai ignore` (ensuring it's a single arg token in the job's
args list) so the PR body passed to CodeRabbit does not contain stray quotes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c83c2567-f38b-4166-934b-d4f085ea578b

📥 Commits

Reviewing files that changed from the base of the PR and between f556d86 and 9afc78b.

📒 Files selected for processing (1)
  • ci-operator/jobs/infra-periodics.yaml

Comment thread ci-operator/jobs/infra-periodics.yaml Outdated
@hector-vido hector-vido force-pushed the removing-coderabbit-dispatcher branch from 9afc78b to ce20ccc Compare April 24, 2026 03:56
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2026
@openshift-ci

openshift-ci Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hector-vido

Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2026
@openshift-ci

openshift-ci Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

@hector-vido: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 8986451 into openshift:main Apr 24, 2026
11 checks passed
Prucek pushed a commit to Prucek/release that referenced this pull request Apr 29, 2026
Co-authored-by: Hector Vido <hector_vido@yahoo.com.br>
BATMAN-JD pushed a commit to BATMAN-JD/release that referenced this pull request May 1, 2026
Co-authored-by: Hector Vido <hector_vido@yahoo.com.br>
fjglira pushed a commit to fjglira/release that referenced this pull request Jun 3, 2026
Co-authored-by: Hector Vido <hector_vido@yahoo.com.br>
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
Co-authored-by: Hector Vido <hector_vido@yahoo.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants