cut new branches for ACM ALC/CLC 5.0 release - #78222
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (27)
📒 Files selected for processing (19)
✅ Files skipped from review due to trivial changes (5)
🚧 Files skipped from review as they are similar to previous changes (11)
WalkthroughAdd new release-5.0 and backplane-5.0 ci-operator configurations with corresponding presubmit/postsubmit Prow job YAMLs across nine repositories. Update main-branch promotion targets from 2.17/backplane-2.17/release-2.17 to 5.0/backplane-5.0/release-5.0, removing legacy fast-forward workflows. Upgrade multicloud-integrations release-2.17 builder from Go 1.24 to 1.25. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
Contributor
|
@xiangjingli, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/stolostron/applifecycle-backend-e2e/stolostron-applifecycle-backend-e2e-release-5.0.yaml`:
- Around line 70-73: The IMAGE_TAG environment variable is an unquoted
numeric-looking YAML scalar (5.0) which can be parsed as a number; update the
env block to set IMAGE_TAG to the quoted string "5.0" so mirror tooling receives
the literal release tag, matching the existing release-2.17 pattern; locate the
env mapping containing IMAGE_REPO/IMAGE_TAG/REGISTRY_ORG and replace the
IMAGE_TAG value with the quoted string "5.0".
In
`@ci-operator/config/stolostron/multicloud-operators-channel/stolostron-multicloud-operators-channel-release-5.0.yaml`:
- Around line 96-105: The IMAGE_TAG currently set to "5.0" should be changed to
the patch-qualified form "5.0.0" so the postsubmit mirrors
stolostron/multicluster-operators-channel:5.0.0; update the IMAGE_TAG entry in
the postsubmit block (where IMAGE_REPO, REGISTRY_ORG and workflow:
ocm-ci-image-mirror are defined) to use "5.0.0" to match the established tagging
convention.
In
`@ci-operator/jobs/stolostron/applifecycle-backend-e2e/stolostron-applifecycle-backend-e2e-release-5.0-postsubmits.yaml`:
- Around line 34-62: The pod specs mount a volume named "gcs-credentials" at
/secrets/gcs but no corresponding volumes entry exists; add a volumes entry for
each postsubmit job that mounts this (the blocks that include mountPath:
/secrets/gcs and name: gcs-credentials) by adding a volume with name:
gcs-credentials and a secret: secretName: gcs-credentials (or the correct
existing GCS secret name used in the repo) so the volumeMount resolves; repeat
the same addition in all three postsubmit job blocks that currently mount
gcs-credentials.
In
`@ci-operator/jobs/stolostron/applifecycle-backend-e2e/stolostron-applifecycle-backend-e2e-release-5.0-presubmits.yaml`:
- Around line 34-56: Add a missing volumes entry for the gcs-credentials mount:
for each presubmit that mounts name: gcs-credentials (mountPath: /secrets/gcs)
add a volumes item with name: gcs-credentials and a secret stanza referencing
the GCS credentials secret (e.g., secretName: gcs-credentials) alongside the
existing manifest-tool-local-pusher, pull-secret, and result-aggregator entries
so the pod volume definitions match the mounts.
In
`@ci-operator/jobs/stolostron/multicloud-operators-subscription/stolostron-multicloud-operators-subscription-release-5.0-postsubmits.yaml`:
- Around line 5-15: The postsubmit job still targets release-2.17 and is
misnamed: update the branches regex under the branches key to ^release-5\.0$ and
rename the job name value (the name:
branch-ci-stolostron-multicloud-operators-subscription-release-2.17-images and
the other three name entries) to use release-5.0 so the jobs run for the
intended branch; also check and, if consistent with the other release-5.0 job
files, change cluster: build03 to cluster: build06 for this job and apply the
same three fixes to the other two job blocks referenced (the blocks at the other
two name/branches/cluster occurrences).
In
`@ci-operator/jobs/stolostron/provider-credential-controller/stolostron-provider-credential-controller-backplane-5.0-postsubmits.yaml`:
- Around line 33-62: The pod specs mount a volume named "gcs-credentials"
(volumeMounts.name: gcs-credentials) but do not define it in the volumes:
section, making the manifests invalid; add a volumes entry for each postsubmit
job that mounts it—e.g., add a volumes item with name: gcs-credentials and
secret: { secretName: gcs-credentials } (or the correct existing GCS secret name
used in the repo) into the same job specs that contain the volumeMounts,
ensuring each of the three postsubmit job specs that reference
volumeMounts.name: gcs-credentials has a matching volumes entry.
In
`@ci-operator/jobs/stolostron/provider-credential-controller/stolostron-provider-credential-controller-backplane-5.0-presubmits.yaml`:
- Around line 33-56: Add a volumes entry matching the existing volumeMount name
"gcs-credentials" so Kubernetes can mount it: under the job's volumes list add a
block with name: gcs-credentials and a secret: secretName: gcs-credentials (or
the correct GCS secret name used in your cluster), ensuring the new volume
matches the container's volumeMounts.name; repeat this addition for each
presubmit job that mounts "gcs-credentials" (the other blocks that have
volumeMounts with name: gcs-credentials).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 358dd8be-dee7-4cdd-8e6f-acf2eff94f02
📒 Files selected for processing (37)
ci-operator/config/stolostron/applifecycle-backend-e2e/stolostron-applifecycle-backend-e2e-main.yamlci-operator/config/stolostron/applifecycle-backend-e2e/stolostron-applifecycle-backend-e2e-release-5.0.yamlci-operator/config/stolostron/cluster-curator-controller/stolostron-cluster-curator-controller-backplane-5.0.yamlci-operator/config/stolostron/cluster-curator-controller/stolostron-cluster-curator-controller-main.yamlci-operator/config/stolostron/cluster-image-set-controller/stolostron-cluster-image-set-controller-backplane-5.0.yamlci-operator/config/stolostron/cluster-image-set-controller/stolostron-cluster-image-set-controller-main.yamlci-operator/config/stolostron/clusterclaims-controller/stolostron-clusterclaims-controller-backplane-5.0.yamlci-operator/config/stolostron/clusterclaims-controller/stolostron-clusterclaims-controller-main.yamlci-operator/config/stolostron/multicloud-integrations/stolostron-multicloud-integrations-main.yamlci-operator/config/stolostron/multicloud-integrations/stolostron-multicloud-integrations-release-2.17.yamlci-operator/config/stolostron/multicloud-integrations/stolostron-multicloud-integrations-release-5.0.yamlci-operator/config/stolostron/multicloud-operators-application/stolostron-multicloud-operators-application-main.yamlci-operator/config/stolostron/multicloud-operators-application/stolostron-multicloud-operators-application-release-5.0.yamlci-operator/config/stolostron/multicloud-operators-channel/stolostron-multicloud-operators-channel-main.yamlci-operator/config/stolostron/multicloud-operators-channel/stolostron-multicloud-operators-channel-release-5.0.yamlci-operator/config/stolostron/multicloud-operators-subscription/stolostron-multicloud-operators-subscription-main.yamlci-operator/config/stolostron/multicloud-operators-subscription/stolostron-multicloud-operators-subscription-release-5.0.yamlci-operator/config/stolostron/provider-credential-controller/stolostron-provider-credential-controller-backplane-5.0.yamlci-operator/config/stolostron/provider-credential-controller/stolostron-provider-credential-controller-main.yamlci-operator/jobs/stolostron/applifecycle-backend-e2e/stolostron-applifecycle-backend-e2e-release-5.0-postsubmits.yamlci-operator/jobs/stolostron/applifecycle-backend-e2e/stolostron-applifecycle-backend-e2e-release-5.0-presubmits.yamlci-operator/jobs/stolostron/cluster-curator-controller/stolostron-cluster-curator-controller-backplane-5.0-postsubmits.yamlci-operator/jobs/stolostron/cluster-curator-controller/stolostron-cluster-curator-controller-backplane-5.0-presubmits.yamlci-operator/jobs/stolostron/cluster-image-set-controller/stolostron-cluster-image-set-controller-backplane-5.0-postsubmits.yamlci-operator/jobs/stolostron/cluster-image-set-controller/stolostron-cluster-image-set-controller-backplane-5.0-presubmits.yamlci-operator/jobs/stolostron/clusterclaims-controller/stolostron-clusterclaims-controller-backplane-5.0-postsubmits.yamlci-operator/jobs/stolostron/clusterclaims-controller/stolostron-clusterclaims-controller-backplane-5.0-presubmits.yamlci-operator/jobs/stolostron/multicloud-integrations/stolostron-multicloud-integrations-release-5.0-postsubmits.yamlci-operator/jobs/stolostron/multicloud-integrations/stolostron-multicloud-integrations-release-5.0-presubmits.yamlci-operator/jobs/stolostron/multicloud-operators-application/stolostron-multicloud-operators-application-release-5.0-postsubmits.yamlci-operator/jobs/stolostron/multicloud-operators-application/stolostron-multicloud-operators-application-release-5.0-presubmits.yamlci-operator/jobs/stolostron/multicloud-operators-channel/stolostron-multicloud-operators-channel-release-5.0-postsubmits.yamlci-operator/jobs/stolostron/multicloud-operators-channel/stolostron-multicloud-operators-channel-release-5.0-presubmits.yamlci-operator/jobs/stolostron/multicloud-operators-subscription/stolostron-multicloud-operators-subscription-release-5.0-postsubmits.yamlci-operator/jobs/stolostron/multicloud-operators-subscription/stolostron-multicloud-operators-subscription-release-5.0-presubmits.yamlci-operator/jobs/stolostron/provider-credential-controller/stolostron-provider-credential-controller-backplane-5.0-postsubmits.yamlci-operator/jobs/stolostron/provider-credential-controller/stolostron-provider-credential-controller-backplane-5.0-presubmits.yaml
Contributor
|
@xiangjingli Please don't add me as a reviewer for PRs in this repo, I am no longer working in this area. Thanks. |
Contributor
Author
|
@chrisahl I didn't add you as a reviewer. Probably you were added automatically by the openshift release repo bot :-) Maybe check it with the repo admin/ |
Contributor
Author
|
/pj-rehearse skip |
Contributor
|
@xiangjingli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Contributor
Author
|
/test ci-operator-config-metadata |
openshift-merge-bot
Bot
removed
the
rehearsals-ack
Contributor
Author
|
/retest |
Contributor
Author
|
/pj-rehearse skip |
Contributor
|
@xiangjingli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
openshift-merge-bot
Bot
removed
the
rehearsals-ack
Contributor
Author
|
/pj-rehearse skip |
Contributor
|
@xiangjingli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Contributor
Author
|
/pj-rehearse skip |
Contributor
|
@xiangjingli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
removed
the
rehearsals-ack
Contributor
|
[REHEARSALNOTIFIER]
A total of 76 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
Author
|
/pj-rehearse skip |
Contributor
|
@xiangjingli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Contributor
Author
Contributor
Author
|
@fxiang1 @mikeshng FYI In case you missed the cutting new 5.0 branches session, the fast forwarding from main to 5.0 in prow pipeline has been removed per requested by installer/build team. They have enabled another fast forwarding cron job running every 2 hours for all syncing up all ACM/MCE main branches to 5.0 and 5.1 branches |
Contributor
Contributor
|
@xiangjingli: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Prucek
pushed a commit
to Prucek/release
that referenced
this pull request
Apr 29, 2026
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
BATMAN-JD
pushed a commit
to BATMAN-JD/release
that referenced
this pull request
May 1, 2026
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
andrej1991
pushed a commit
to andrej1991/release
that referenced
this pull request
Jul 6, 2026
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
TimurMP
pushed a commit
to TimurMP/release
that referenced
this pull request
Jul 8, 2026
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
SachinNinganure
pushed a commit
to SachinNinganure/release
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
falconizmi
added a commit
to falconizmi/openshift-release
that referenced
this pull request
Jul 22, 2026
ci-operator can auto-detect base_images and inputs from Dockerfile FROM lines (see https://docs.ci.openshift.org/architecture/ci-operator/#automatic-detection-from-dockerfiles). These were mass-cleaned in PR openshift#74942 but the 2.17 and 5.0 branch configs were created after that cleanup (PRs openshift#74846, openshift#78222) and still had the redundant entries. Also removes dead go1.24 base_images entries from provider-credential-controller and multicloud-integrations. Repos: cluster-curator-controller, cluster-image-set-controller, provider-credential-controller, multicloud-operators-application, multicloud-operators-channel, multicloud-integrations, multicloud-operators-subscription Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
falconizmi
added a commit
to falconizmi/openshift-release
that referenced
this pull request
Jul 22, 2026
ci-operator can auto-detect base_images and inputs from Dockerfile FROM lines (see https://docs.ci.openshift.org/architecture/ci-operator/#automatic-detection-from-dockerfiles). These were mass-cleaned in PR openshift#74942 but the 2.17 and 5.0 branch configs were created after that cleanup (PRs openshift#74846, openshift#78222) and still had the redundant entries. Also removes dead go1.24 base_images entries from provider-credential-controller and multicloud-integrations. Repos: cluster-curator-controller, cluster-image-set-controller, provider-credential-controller, multicloud-operators-application, multicloud-operators-channel, multicloud-integrations, multicloud-operators-subscription Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-merge-bot Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
* remove auto-detectable base_images and inputs for ALC/CLC repos ci-operator can auto-detect base_images and inputs from Dockerfile FROM lines (see https://docs.ci.openshift.org/architecture/ci-operator/#automatic-detection-from-dockerfiles). These were mass-cleaned in PR #74942 but the 2.17 and 5.0 branch configs were created after that cleanup (PRs #74846, #78222) and still had the redundant entries. Also removes dead go1.24 base_images entries from provider-credential-controller and multicloud-integrations. Repos: cluster-curator-controller, cluster-image-set-controller, provider-credential-controller, multicloud-operators-application, multicloud-operators-channel, multicloud-integrations, multicloud-operators-subscription Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * bump build_root to go1.26-linux for ALC/CLC repos Update CI builder image to Go 1.26 across all supported branches to address CVE-2026-27145 (crypto/x509 DoS). Repos: cluster-curator-controller, clusterclaims-controller, cluster-image-set-controller, provider-credential-controller, multicloud-operators-application, multicloud-operators-channel, multicloud-integrations, multicloud-operators-subscription CLC branches: main, backplane-2.6, 2.8, 2.9, 2.10, 2.11, 2.17, 5.0 ALC branches: main, release-2.11, 2.13, 2.14, 2.15, 2.16, 2.17, 5.0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
apahim
pushed a commit
to apahim/release
that referenced
this pull request
Jul 24, 2026
* remove auto-detectable base_images and inputs for ALC/CLC repos ci-operator can auto-detect base_images and inputs from Dockerfile FROM lines (see https://docs.ci.openshift.org/architecture/ci-operator/#automatic-detection-from-dockerfiles). These were mass-cleaned in PR openshift#74942 but the 2.17 and 5.0 branch configs were created after that cleanup (PRs openshift#74846, openshift#78222) and still had the redundant entries. Also removes dead go1.24 base_images entries from provider-credential-controller and multicloud-integrations. Repos: cluster-curator-controller, cluster-image-set-controller, provider-credential-controller, multicloud-operators-application, multicloud-operators-channel, multicloud-integrations, multicloud-operators-subscription Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * bump build_root to go1.26-linux for ALC/CLC repos Update CI builder image to Go 1.26 across all supported branches to address CVE-2026-27145 (crypto/x509 DoS). Repos: cluster-curator-controller, clusterclaims-controller, cluster-image-set-controller, provider-credential-controller, multicloud-operators-application, multicloud-operators-channel, multicloud-integrations, multicloud-operators-subscription CLC branches: main, backplane-2.6, 2.8, 2.9, 2.10, 2.11, 2.17, 5.0 ALC branches: main, release-2.11, 2.13, 2.14, 2.15, 2.16, 2.17, 5.0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit