Handle WHAT/INSTANCE_PREFIX env var mapping better#511
Closed
dobbymoodge wants to merge 1 commit into
Closed
Conversation
openshift-ci-robot
added
the
size/S
Contributor
There was a problem hiding this comment.
I don't want to do this here, it's inconsistent with other makefiles. We should always set INSTANCE_PREFIX to WHAT, not default it.
Contributor
Author
There was a problem hiding this comment.
Reverted this change.
dobbymoodge
force-pushed
the
test_deploy_say_what
branch
from
c8ce00c to
d09ce8b
Compare
openshift-ci-robot
added
size/XS
dobbymoodge
force-pushed
the
test_deploy_say_what
branch
from
d09ce8b to
2fa9d25
Compare
openshift-ci-robot
added
size/S
Contributor
Author
|
@smarterclayton updated |
Contributor
|
Maybe I wasn’t clear - I don’t want the variable to be conditional, it has to be set in those jobs to a value. Don’t make setting it conditional. |
Contributor
|
No, reread (though it was same file). |
Contributor
|
Nm |
Contributor
There was a problem hiding this comment.
Is there a reason we can’t make this an unconditional equality? Ie remove the “?”
Contributor
Author
There was a problem hiding this comment.
?? That's what this PR does ??
Contributor
Author
There was a problem hiding this comment.
@smarterclayton Any chance getting some clarification on this comment?
Contributor
Author
There was a problem hiding this comment.
@smarterclayton This is needed for me to automate pruning, ptal and merge
openshift-bot
added
the
needs-rebase
dobbymoodge
force-pushed
the
test_deploy_say_what
branch
from
2fa9d25 to
4171041
Compare
openshift-bot
removed
the
needs-rebase
dobbymoodge
force-pushed
the
test_deploy_say_what
branch
from
4171041 to
3cbb2eb
Compare
dobbymoodge
force-pushed
the
test_deploy_say_what
branch
from
3cbb2eb to
e9a3407
Compare
Change this in `cluster/test_deploy/Makefile` and `cluster/ci/Makefile` to maintain consistent behavior.
dobbymoodge
force-pushed
the
test_deploy_say_what
branch
from
e9a3407 to
0496526
Compare
Member
|
/test all |
Member
|
/close |
Contributor
|
@droslean: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
@dobbymoodge: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2 tasks
3 tasks
dustman9000
added a commit
to dustman9000/release
that referenced
this pull request
Jul 2, 2026
Several SRE operator repos only required ci/prow/images in branch protection, allowing PRs to merge with failing lint, test, coverage, and validate checks. Discovered when Dependabot auto-merge merged cloud-ingress-operator PRs openshift#505-openshift#511 with 3 failing checks. Remove skip_if_only_changed from CI configs so all tests are always_run, then add them to required_status_checks in branch protection. The skip_if_only_changed optimization saved CI time on docs-only PRs but conflicted with required_status_checks (checkconfig rejects contexts that are both required and required-if-present). Repos updated (12): - cloud-ingress-operator - configure-alertmanager-operator - custom-domains-operator (new branch-protection) - deadmanssnitch-operator - splunk-forwarder-operator (new branch-protection) - must-gather-operator (new branch-protection) - aws-account-operator - gcp-project-operator - managed-velero-operator - managed-cluster-validating-webhooks - osd-cluster-ready - pagerduty-operator
dustman9000
added a commit
to dustman9000/release
that referenced
this pull request
Jul 2, 2026
Several SRE operator repos only required ci/prow/images in branch protection, allowing PRs to merge with failing lint, test, coverage, and validate checks. Discovered when Dependabot auto-merge merged cloud-ingress-operator PRs openshift#505-openshift#511 with 3 failing checks. Remove skip_if_only_changed and run_if_changed from CI configs so all tests become always_run, then add them to required_status_checks in branch protection. These conditional run optimizations saved CI time on docs-only PRs but conflicted with required_status_checks (checkconfig --strict rejects contexts that are both required and required-if-present). Repos updated (12): - cloud-ingress-operator - configure-alertmanager-operator - custom-domains-operator (new branch-protection) - deadmanssnitch-operator - splunk-forwarder-operator (new branch-protection) - must-gather-operator (new branch-protection) - aws-account-operator - gcp-project-operator - managed-velero-operator - managed-cluster-validating-webhooks - osd-cluster-ready - pagerduty-operator
dustman9000
added a commit
to dustman9000/release
that referenced
this pull request
Jul 2, 2026
Several SRE operator repos only required ci/prow/images in branch protection, allowing PRs to merge with failing lint, test, coverage, and validate checks. Discovered when Dependabot auto-merge merged cloud-ingress-operator PRs openshift#505-openshift#511 with 3 failing checks. Remove skip_if_only_changed and run_if_changed from CI configs so all tests become always_run, then add them to required_status_checks in branch protection. These conditional run optimizations saved CI time on docs-only PRs but conflicted with required_status_checks (checkconfig --strict rejects contexts that are both required and required-if-present). Repos updated (12): - cloud-ingress-operator - configure-alertmanager-operator - custom-domains-operator (new branch-protection) - deadmanssnitch-operator - splunk-forwarder-operator (new branch-protection) - must-gather-operator (new branch-protection) - aws-account-operator - gcp-project-operator - managed-velero-operator - managed-cluster-validating-webhooks - osd-cluster-ready - pagerduty-operator
dustman9000
added a commit
to dustman9000/release
that referenced
this pull request
Jul 2, 2026
Several SRE operator repos only required ci/prow/images in branch protection, allowing PRs to merge with failing lint, test, coverage, and validate checks. Discovered when Dependabot auto-merge merged cloud-ingress-operator PRs openshift#505-openshift#511 with 3 failing checks. Three changes per repo: 1. Remove skip_if_only_changed/run_if_changed from CI configs so all tests become always_run 2. Add all non-optional checks to required_status_checks in branch protection prowconfigs 3. Replace required-if-present-contexts in _config.yaml with skip-unknown-contexts (matching rbac-permissions-operator pattern) to avoid checkconfig conflict Repos updated (12): - cloud-ingress-operator - configure-alertmanager-operator - custom-domains-operator (new branch-protection) - deadmanssnitch-operator - splunk-forwarder-operator (new branch-protection) - must-gather-operator (new branch-protection) - aws-account-operator - gcp-project-operator - managed-velero-operator - managed-cluster-validating-webhooks - osd-cluster-ready - pagerduty-operator
openshift-merge-bot Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
…1412) Several SRE operator repos only required ci/prow/images in branch protection, allowing PRs to merge with failing lint, test, coverage, and validate checks. Discovered when Dependabot auto-merge merged cloud-ingress-operator PRs #505-#511 with 3 failing checks. Three changes per repo: 1. Remove skip_if_only_changed/run_if_changed from CI configs so all tests become always_run 2. Add all non-optional checks to required_status_checks in branch protection prowconfigs 3. Replace required-if-present-contexts in _config.yaml with skip-unknown-contexts (matching rbac-permissions-operator pattern) to avoid checkconfig conflict Repos updated (12): - cloud-ingress-operator - configure-alertmanager-operator - custom-domains-operator (new branch-protection) - deadmanssnitch-operator - splunk-forwarder-operator (new branch-protection) - must-gather-operator (new branch-protection) - aws-account-operator - gcp-project-operator - managed-velero-operator - managed-cluster-validating-webhooks - osd-cluster-ready - pagerduty-operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.