Skip to content

Remove systemd-devel test dependency - #2604

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
0xmichalis:rm-systemd-devel
Jan 15, 2019
Merged

Remove systemd-devel test dependency#2604
openshift-merge-robot merged 1 commit into
openshift:masterfrom
0xmichalis:rm-systemd-devel

Conversation

@0xmichalis

Copy link
Copy Markdown
Contributor

@jim-minter we don't need systemd-devel anymore in our test base image, is that correct?

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kargakis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added sig/azure Categorizes item related to Azure jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2019
@0xmichalis 0xmichalis changed the title Remove systemd-devel test dependancy Remove systemd-devel test dependency Jan 15, 2019
@0xmichalis

Copy link
Copy Markdown
Contributor Author

/test all

@0xmichalis 0xmichalis added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2019
@openshift-merge-robot
openshift-merge-robot merged commit 7b982b9 into openshift:master Jan 15, 2019
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Kargakis: Updated the job-config configmap using the following files:

  • key openshift-openshift-azure-master-presubmits.yaml using file ci-operator/jobs/openshift/openshift-azure/openshift-openshift-azure-master-presubmits.yaml
Details

In response to this:

@jim-minter we don't need systemd-devel anymore in our test base image, is that correct?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-azure-robot

Copy link
Copy Markdown

@Kargakis: The following updates succeeded:

  • /usr/bin/make apply WHAT=projects/azure/base-images/test-base.yaml
    
    $ /usr/bin/make apply WHAT=projects/azure/base-images/test-base.yaml
    oc apply -f projects/azure/base-images/test-base.yaml
    imagestream "test-base" unchanged
    buildconfig "test-base" configured
    

Details

In response to this:

@jim-minter we don't need systemd-devel anymore in our test base image, is that correct?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/azure Categorizes item related to Azure jobs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants