Skip to content

ROSA-745: boilerplate-update after openshift/boilerplate#748#648

Closed
MitaliBhalla wants to merge 2 commits into
openshift:masterfrom
MitaliBhalla:rosa-745-boilerplate-update
Closed

ROSA-745: boilerplate-update after openshift/boilerplate#748#648
MitaliBhalla wants to merge 2 commits into
openshift:masterfrom
MitaliBhalla:rosa-745-boilerplate-update

Conversation

@MitaliBhalla

@MitaliBhalla MitaliBhalla commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

ROSA-745: make boilerplate-update after openshift/boilerplate#748.

Picks up Dependabot docker template changes (lgtm/approved, Mon 03:00 UTC) and latest boilerplate-managed files.

make boilerplate-update does not refresh an existing boilerplate-managed .github/dependabot.yml; this PR syncs it from the #748 template (docker-only).

Renovate/MintMaker gomod rules are inherited via extends: openshift/boilerplate — no renovate change in this PR.

Test plan

  • CI green (prow + Konflux)
  • Dependabot docker PRs get lgtm/approved after merge

Jira: ROSA-745

Summary by CodeRabbit

  • Chores
    • Updated dependency update scheduling to occur weekly on Mondays at 3 AM UTC for improved predictability.

Pick up Dependabot docker automerge labels/schedule from boilerplate.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 11, 2026

Copy link
Copy Markdown

@MitaliBhalla: This pull request references ROSA-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the initiative to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

ROSA-745: make boilerplate-update after openshift/boilerplate#748.

Picks up Dependabot docker template changes (lgtm/approved, Mon 03:00 UTC) and latest boilerplate-managed files.

make boilerplate-update does not refresh an existing boilerplate-managed .github/dependabot.yml; this PR syncs it from the #748 template (docker-only).

Renovate/MintMaker gomod rules are inherited via extends: openshift/boilerplate — no renovate change in this PR.

Test plan

  • CI green (prow + Konflux)
  • Dependabot docker PRs get lgtm/approved after merge

Jira: ROSA-745

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@MitaliBhalla, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 48 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: edfe4b76-d5da-438d-9aad-232ef7dd7c52

📥 Commits

Reviewing files that changed from the base of the PR and between 3ed2684 and d7b0687.

📒 Files selected for processing (1)
  • .github/dependabot.yml

Walkthrough

Dependabot configuration for Docker ecosystem updates is modified to explicitly define the weekly schedule: updates run on Mondays at 03:00 UTC. Previously, only the weekly interval was specified without day, time, or timezone details.

Changes

Dependabot Schedule Update

Layer / File(s) Summary
Docker update schedule specification
.github/dependabot.yml
Docker ecosystem update schedule is expanded to specify execution on Monday at 03:00 UTC instead of only the weekly interval.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved

Suggested reviewers

  • TheUndeadKing
  • tkong-redhat
🚥 Pre-merge checks | ✅ 12 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning 69 Ginkgo test files added lack meaningful assertion messages (0/143+ Expect calls have messages) and podDeleteStrategy_test.go has no AfterEach cleanup, violating check requirements 2 and 4. Add meaningful failure messages to all Expect assertions (e.g., "Expect(err).NotTo(HaveOccurred(), \"failed to...\")" and add AfterEach with mockCtrl.Finish() to all test files creating mocks.
Microshift Test Compatibility ⚠️ Warning New Ginkgo e2e tests in test/e2e/managed_upgrade_operator_tests.go use ClusterVersion API (config.openshift.io/v1) and prometheus metrics, which are not available on MicroShift, with no MicroShift... Add [apigroup:config.openshift.io] tags to affected tests or guard with IsMicroShiftCluster() check with g.Skip() call, following the recommendation in the custom check instructions.
Topology-Aware Scheduling Compatibility ⚠️ Warning PR introduces deployment manifests (deploy/operator.yaml) with nodeAffinity targeting control-plane nodes using node-role.kubernetes.io/master label without topology-awareness. On HyperShift (Exter... Update deploy/operator.yaml to check ControlPlaneTopology and avoid node-role.kubernetes.io/master selectors on External topologies, or use topology-agnostic scheduling (e.g., prefer topology handling via library-go DeploymentController...
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: a boilerplate update that incorporates Dependabot configuration changes from the referenced upstream issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed All 69 newly added test files in the boilerplate update contain stable, deterministic test names without dynamic information like generated suffixes, timestamps, UUIDs, node names, or IP addresses.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR is a boilerplate update with no new Ginkgo e2e tests added; check only applies to new test code.
Ote Binary Stdout Contract ✅ Passed PR only modifies configuration files (.github/dependabot.yml) and boilerplate infrastructure; no Go source code changes that could violate OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed New Ginkgo e2e tests in test/e2e/managed_upgrade_operator_tests.go contain no IPv4 assumptions, hardcoded IPv4 addresses, or external connectivity requirements. Tests use only cluster-internal APIs...
No-Weak-Crypto ✅ Passed PR contains only configuration file changes (.github/dependabot.yml) with no cryptographic code, weak crypto algorithms, or insecure patterns added.
Container-Privileges ✅ Passed PR contains no privileged container settings. All container manifests found (e2e-template.yml) have allowPrivilegeEscalation: false, runAsNonRoot: true, and capabilities dropped—no security violati...
No-Sensitive-Data-In-Logs ✅ Passed PR only modifies .github/dependabot.yml configuration file with schedule parameters; contains no logging statements or sensitive data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from devppratik and ravitri June 11, 2026 05:05
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MitaliBhalla
Once this PR has been reviewed and has the lgtm label, please assign theautoroboto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Match ose-operator-registry-rhel9 in build/Dockerfile.olm-registry.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.33%. Comparing base (c811aa8) to head (d7b0687).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   54.33%   54.33%           
=======================================
  Files         123      123           
  Lines        6212     6212           
=======================================
  Hits         3375     3375           
  Misses       2631     2631           
  Partials      206      206           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MitaliBhalla

MitaliBhalla commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Closing pending MCWV MintMaker pilot validation (openshift/managed-cluster-validating-webhooks#553).

Will reopen a consolidated ROSA-745 PR per repo after #553 merges, including:

  • explicit enabledManagers tekton/gomod in renovate.json
  • docker-only Dependabot with build/-derived ignores
  • boilerplate-update where needed

Jira: ROSA-745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants