OCPBUGS-44505: remove crypto-browserify library and use Crypto instead

[Mylanos]

This PR replaces the use of crypto-browserify for generating a hash for a given username with the native Crypto object and its subtle.digest method, which is supported in all browsers compatible with v4.21. This way we not only remove unnecessary dependencies, but also use browser-optimized native cryptographic functionality.

Changes in this PR:

• Replaced crypto-browserify's createHash function with a newly implemented generateHash function that utilizes browser-native Crypto.subtle.digest.
• Removed crypto-browserify from the dependencies as this was its sole usage in the codebase.

[openshift-ci-robot]

@Mylanos: This pull request references Jira Issue OCPBUGS-44505, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Mylanos]

/jira refresh

[openshift-ci-robot]

@Mylanos: This pull request references Jira Issue OCPBUGS-44505, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cajieh]

/retest

[Mylanos]

/retest

[Mylanos]

/retest

[spadgett]

/lgtm

👍

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d878879 and 2 for PR HEAD c771cf1d2e1dac5526e99c783bc3e402c89210c5 in total

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-44505, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

to be honest this looks mergable as-is

/retitle OCPBUGS-44505: remove crypto-browserify library and use Crypto instead
/unhold
/jira refresh
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, Mylanos, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[logonoff]

/verified later @yapei

[openshift-ci-robot]

@logonoff: This PR has been marked to be verified later by @yapei.

Details

In response to this:

/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1e64b1f and 2 for PR HEAD 51d84f5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 90b613a and 1 for PR HEAD 51d84f5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1bae6b5 and 0 for PR HEAD 51d84f5 in total

[openshift-ci-robot]

/hold

Revision 51d84f5 was retested 3 times: holding

[logonoff]

/retest

[jhadvig]

/retest

[openshift-ci]

@Mylanos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	51d84f5	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-44505, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[logonoff]

/close

Removed in #15892 but in another way

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@logonoff: Closed this PR.

Details

In response to this:

/close

Removed in #15892 but in another way

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@Mylanos: This pull request references Jira Issue OCPBUGS-44505. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This PR replaces the use of crypto-browserify for generating a hash for a given username with the native Crypto object and its subtle.digest method, which is supported in all browsers compatible with v4.21. This way we not only remove unnecessary dependencies, but also use browser-optimized native cryptographic functionality.

Changes in this PR:

• Replaced crypto-browserify's createHash function with a newly implemented generateHash function that utilizes browser-native Crypto.subtle.digest.
• Removed crypto-browserify from the dependencies as this was its sole usage in the codebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.