graph-builder/metrics: track timestamp of last graph refresh - #136
Merged
openshift-merge-robot merged 3 commits intoJul 29, 2019
Conversation
openshift-ci-robot
added
size/M
steveej
reviewed
Jul 29, 2019
steveej
left a comment
steveej
left a comment
Contributor
There was a problem hiding this comment.
LGTM in general. Just some naming nitpicking and possible code refactor comments.
This instruments and tracks via metrics the timestamp of last successful graph refresh.
lucab
force-pushed
the
ups/gb-last-refresh
branch
from
July 29, 2019 15:54
8a3d98c to
43f39e8
Compare
Contributor
Author
|
@steveej I've amended with one relevant suggestion of yours, and re-pushed. |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucab, steveeJ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This instruments and tracks via metrics the timestamp of last
successful graph refresh.
Ref: https://jira.coreos.com/browse/CIN-60
/cc @steveej