Remove cluster-init from check-breaking-changes

[danilo-gemoli]

Since it is permafailing and we are struggling to keep it up to date with the changes we make in o/release.

Removed cluster-init validation from breaking changes check

This PR removes the cluster-init onboard config update validation step from the test/validate-generation-breaking-changes.sh script (19 lines removed).

The breaking changes validation script tests whether changes to ci-tools would break the openshift/release repository by running tools like ci-operator-prowgen, sanitize-prow-jobs, and determinize-prow-config and checking for unexpected changes. Previously, it also included a cluster-init onboard config update validation step.

This cluster-init check is being removed because it is consistently failing and difficult to keep in sync with changes made in the openshift/release repository. The rest of the validation (prowgen, sanitize-prow-jobs, and determinize-prow-config checks) remains intact and will continue to detect if changes to ci-tools break the release repo configuration.

This change improves CI reliability by removing a persistent failure point from the breaking changes validation pipeline while maintaining validation for the tools that are actively maintained.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 029702bb-048b-4f4e-8b38-997d68c4729b

📥 Commits

Reviewing files that changed from the base of the PR and between aeb8c9d and a78851f.

📒 Files selected for processing (1)

• test/validate-generation-breaking-changes.sh

💤 Files with no reviewable changes (1)

• test/validate-generation-breaking-changes.sh

---

📝 Walkthrough

Walkthrough

The breaking-changes validation script removes the cluster-init update mode check. The script continues to clone repos and run prowgen, sanitize, and determinize steps but no longer validates changes via cluster-init onboard config update.

Changes

Cluster-init Validation Removal

Layer / File(s)	Summary
Remove cluster-init update mode validation test/validate-generation-breaking-changes.sh	Deletion of the conditional block that checked KUBECONFIG_DIR and ran cluster-init onboard config update, including its associated failure reporting based on git diffs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• openshift/ci-tools#4811: Modifies the breaking-changes test's cluster-init behavior; the related PR adds a KUBECONFIG_DIR check while this PR removes the cluster-init step entirely.

Suggested labels

approved, lgtm

Suggested reviewers

• pruan-rht
• Prucek
• deepsm007

🚥 Pre-merge checks | ✅ 14

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing cluster-init validation from the breaking changes check script, which aligns with the PR summary and code changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	The PR modifies only a shell script (test/validate-generation-breaking-changes.sh), not Go code. The "Go Error Handling" custom check is not applicable to this change.
Test Coverage For New Features	✅ Passed	Shell script modification removing broken validation logic. No new Go functions or methods added. Change falls under "configuration-only changes" exception for test infrastructure scripts.
Stable And Deterministic Test Names	✅ Passed	Custom check for Ginkgo test names not applicable. PR modifies only a bash shell script and the codebase uses standard Go testing, not Ginkgo.
Test Structure And Quality	✅ Passed	Custom check not applicable. PR modifies a bash shell script, not Ginkgo test code. Ginkgo checks apply only to Go test files with Describe/It blocks.
Microshift Test Compatibility	✅ Passed	Not applicable. PR modifies a shell script to remove cluster-init validation; it does not add new Ginkgo e2e tests. The check only applies when e2e tests are added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only removes lines from a shell script used for validation/CI infrastructure. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies a test script only. No deployment manifests, operator code, or Kubernetes scheduling constraints present. Topology-aware scheduling check not applicable.
Ote Binary Stdout Contract	✅ Passed	The PR modifies only a shell script, not Go/Ginkgo binaries. The OTE Binary Stdout Contract applies only to Go test binaries. Shell scripts cannot violate this contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Check not applicable: PR modifies a shell script validation utility, not Ginkgo e2e tests. No new e2e tests added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[psalajova]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, psalajova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [danilo-gemoli,psalajova]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

• The changed files don't match any pipeline_run_if_changed patterns
• All files match pipeline_skip_if_only_changed patterns
• No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.