HYPERFLEET-786 - chore: align chart with Helm conventions standard - #87
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughHelm chart defaults and templates were modified: Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
dacd7aa to
d6faec9
Compare
xueli181114
changed the title
ee0b95a to
b551d62
Compare
b551d62 to
f9c946e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
34ae499
into
openshift-hyperfleet:main
…enshift-hyperfleet#87) ## Summary - Add OTLP span exporter to `pkg/otel/tracer.go` so traces are sent to a backend when `OTEL_EXPORTER_OTLP_ENDPOINT` is configured - When no endpoint is set, TracerProvider still generates trace IDs and span IDs for log correlation (no behavior change from current) - Support both gRPC (default) and HTTP protocols via `OTEL_EXPORTER_OTLP_PROTOCOL` - Spans are batched via `BatchSpanProcessor` for efficient export - Accept `logger.Logger` in `InitTracer` instead of creating one internally ## Changes - `pkg/otel/tracer.go` — Added `createExporter()`, updated `InitTracer` signature to accept logger, conditionally register `WithBatcher(exporter)` - `pkg/otel/tracer_test.go` — Tests for sample ratio parsing, exporter creation, and TracerProvider initialization - `cmd/adapter/main.go` — Pass logger to `InitTracer` - `go.mod` / `go.sum` — Added `otlptracegrpc`, `otlptracehttp` dependencies ## Test plan - [x] Unit tests pass (`go test ./pkg/otel/... -v`) - [x] Full unit test suite passes (`go test ./...` excluding integration) - [x] Built and pushed dev image (`quay.io/xueli/hyperfleet-adapter:dev-6baad90`) - [x] Deployed to GKE dev cluster, verified startup logs confirm tracer initialization - [x] Verified trace_id and span_id appear in logs when processing events - [x] Verified trace_id propagation from upstream CloudEvent `traceparent` extension - [x] Verified metrics scraped by Prometheus via ServiceMonitor <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * OTLP span exporter added with support for both HTTP and gRPC protocols for flexible tracing. * Tracing now operates without an exporter when none is configured (no impact if OTLP endpoint unset). * **Bug Fixes** * Improved cleanup: exporter shutdown is attempted on initialization errors to avoid resource leaks. * **Tests** * Added tests covering trace sampling, exporter creation, and tracer initialization/shutdown. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
HYPERFLEET-1016 - refactor: Replace Ready condition references with Reconciled
3 participants
Summary
The Helm chart values were changed: image.repository in charts/values.yaml was set from hyperfleet-api to CHANGE_ME, image.tag was changed from "latest" to "", and a new top-level podLabels: {} value was added alongside podAnnotations. The Deployment template (charts/templates/deployment.yaml) was updated so the pod template metadata.labels conditionally includes labels from .Values.podLabels (rendered via toYaml) in addition to the existing selector labels.
Test plan
make test-helmpasses (all 9 scenarios)Relates to: HYPERFLEET-786
Depends on: architecture#108
Summary by CodeRabbit