HYPERFLEET-734 - fix: use 0.0.0-dev version for dev image builds#77
Merged
openshift-merge-bot[bot] merged 1 commit intoMar 10, 2026
Merged
Conversation
The image-dev target was using APP_VERSION from git describe, which picks up release tags and gives dev images misleading version strings. Override to 0.0.0-dev to clearly distinguish dev builds from releases.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request modifies the Makefile's Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rh-amarin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Mar 10, 2026
c9bf241
into
openshift-hyperfleet:main
8 checks passed
kuudori
pushed a commit
to kuudori/hyperfleet-api
that referenced
this pull request
Jul 14, 2026
… ditions (openshift-hyperfleet#77) # Summary - Add `now()` Custom CEL Function for Time-Based ditions # Testing - `make test-all` passed - The new built dev image can work well with the passed log. ``` time=2026-03-13T08:36:24.667Z level=DEBUG msg="Evaluating CEL expression: readyCondition == null || readyCondition.status != \"True\" ||\n(timestamp(currentTime) - timestamp(readyCondition.last_transition_time)).getSeconds() >= TTL_EXPIRY_THRESHOLD" component=cl-job version=v0.1.1-dirty hostname=adapter-clusters-cl-job-6868645549-ld7m9 event_id=a12e79ca-484c-44f8-83b5-d5b6b09f9429 trace_id=b6c8ae918a46a05342b1db86fee559a5 span_id=da43d4265d2e7988 cluster_id=2p0lte3ga0gefgnl66pb1em99hoe1jv2 time=2026-03-13T08:36:24.667Z level=DEBUG msg="CEL result: matched=true value=true" component=cl-job version=v0.1.1-dirty hostname=adapter-clusters-cl-job-6868645549-ld7m9 cluster_id=2p0lte3ga0gefgnl66pb1em99hoe1jv2 event_id=a12e79ca-484c-44f8-83b5-d5b6b09f9429 trace_id=b6c8ae918a46a05342b1db86fee559a5 span_id=da43d4265d2e7988 time=2026-03-13T08:36:24.667Z level=INFO msg="Precondition[validationCheck] evaluated: MET" component=cl-job version=v0.1.1-dirty hostname=adapter-clusters-cl-job-6868645549-ld7m9 event_id=a12e79ca-484c-44f8-83b5-d5b6b09f9429 trace_id=b6c8ae918a46a05342b1db86fee559a5 span_id=da43d4265d2e7988 cluster_id=2p0lte3ga0gefgnl66pb1em99hoe1jv2 ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a `now()` CEL function that returns the current timestamp in RFC3339 format, enabling time-based expressions and calculations within preconditions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
kuudori
pushed a commit
to kuudori/hyperfleet-api
that referenced
this pull request
Jul 14, 2026
HYPERFLEET-733 - fix: sentinel delays first event publish for newly created clusters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APP_VERSIONto0.0.0-devin theimage-devMakefile target instead of usinggit describe --tagsJira
https://issues.redhat.com/browse/HYPERFLEET-734
Summary by CodeRabbit