Skip to content

HYPERFLEET-730 - fix: copy CA certificates from builder to ubi9-micro runtime#74

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
xueli181114:HYPERFLEET-730
Mar 9, 2026
Merged

HYPERFLEET-730 - fix: copy CA certificates from builder to ubi9-micro runtime#74
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
xueli181114:HYPERFLEET-730

Conversation

@xueli181114

@xueli181114 xueli181114 commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Copy CA trust bundle from builder stage to ubi9-micro runtime image
  • Fixes TLS failures (x509: certificate signed by unknown authority) when connecting to external services (e.g. Google Pub/Sub)
  • ubi9-micro is extremely minimal and doesn't include CA certificates; Go static binaries (CGO_ENABLED=0) need system CA certs for TLS verification

Test plan

  • CI passes

Fixes: HYPERFLEET-730

Summary by CodeRabbit

  • Bug Fixes
    • Fixed missing TLS certificates in the runtime environment to enable secure connections for services requiring certificate validation.

…-micro runtime

ubi9-micro doesn't include ca-certificates, causing TLS failures
(x509: certificate signed by unknown authority) when connecting to
external services like Google Pub/Sub. Copy the CA trust bundle from
the builder stage to fix this.
@openshift-ci
openshift-ci Bot requested review from aredenba-rh and rafabene March 9, 2026 08:47
@coderabbitai

coderabbitai Bot commented Mar 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af9efa41-47eb-4c3e-9ed1-87efc33110ec

📥 Commits

Reviewing files that changed from the base of the PR and between 43a4f86 and d523134.

📒 Files selected for processing (1)
  • Dockerfile

Walkthrough

The change modifies the Dockerfile to copy the CA bundle from the builder stage into the final runtime image. Specifically, it adds a COPY --from=builder instruction to transfer /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem from the builder stage to the same path in the final image. This ensures CA certificates are available in the ubi9-micro-based runtime environment, enabling TLS connectivity for services.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: copying CA certificates from builder to ubi9-micro runtime to fix TLS issues. It is specific, concise, and directly summarizes the primary changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@ciaranRoche ciaranRoche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Mar 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Mar 9, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit f7fa37b into openshift-hyperfleet:main Mar 9, 2026
8 checks passed
kuudori pushed a commit to kuudori/hyperfleet-api that referenced this pull request Jul 14, 2026
…nshift-hyperfleet#74)

## Summary

- Override `APP_VERSION` to `0.0.0-dev` in the `image-dev` Makefile
target instead of using `git describe --tags`
- Dev images should not carry release tag version strings

## Jira

https://issues.redhat.com/browse/HYPERFLEET-734

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
  * Updated development build configuration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
kuudori pushed a commit to kuudori/hyperfleet-api that referenced this pull request Jul 14, 2026
HYPERFLEET-368: Fail fast check implemented on HyperFleet API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants