HYPERFLEET-1246 - chore: upgrade hyperfleet-api-spec to v1.0.23

[rh-amarin]

Summary

• Bumps github.com/openshift-hyperfleet/hyperfleet-api-spec from the previous version to v1.0.23
• Adapts all code to the breaking type change: Kind field changed from *string to string in ClusterCreateRequest, NodePoolCreateRequest, Cluster, NodePool, and ObjectReference
• Updates presenter logic, unit tests, and integration tests accordingly

Changes

Source files:

• pkg/api/presenters/cluster.go — remove nil-pointer check on req.Kind; use cluster.Kind (string) directly in response
• pkg/api/presenters/node_pool.go — same pattern; use nodePool.Kind and nodePool.OwnerKind directly
• pkg/api/presenters/resource.go — dereference *string domain field via util.NilToEmptyString for ObjectReference.Kind

Test files: remove util.PtrString()/&kind pointer literals when constructing request bodies; remove * dereference on Kind and OwnerReferences.Kind assertions across unit and integration tests.

Test plan

• make test — 1264 unit tests pass
• make test-integration — 198 integration tests pass (2 expected skips)

🤖 Generated with Claude Code

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved API responses and request handling for cluster and node pool kind values, including better fallback behavior when the field is empty.
  • Standardized returned kind fields in related API flows so responses are more consistent across create, update, list, and get operations.
  • Updated an API dependency to a newer version for compatibility and stability.

Walkthrough

go.mod bumps github.com/openshift-hyperfleet/hyperfleet-api-spec from v1.0.21 to v1.0.23. That spec version changes Kind fields on ClusterCreateRequest, NodePoolCreateRequest, Cluster, NodePool, and related OwnerReferences types from *string to string. ConvertCluster and ConvertNodePool switch from pointer-nil checks to empty-string fallback logic. PresentCluster and PresentNodePool assign Kind directly without pointer wrapping. PresentResource wraps OwnerKind through util.NilToEmptyString. All unit, handler, and integration tests remove util.PtrString calls and pointer dereferences accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 29.41% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately states the dependency upgrade and target version.
Description check	✅ Passed	The description is directly related to the dependency bump and the resulting Kind type changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output	✅ Passed	No non-test log/Print calls in the touched production files mention token/password/credential/secret; CWE-532 not triggered.
No Hardcoded Secrets	✅ Passed	No hardcoded secrets found in touched files; scans of presenters/tests/go.mod found no API keys, tokens, passwords, private keys, embedded creds, or long base64 literals. CWE-798/259 absent.
No Weak Cryptography	✅ Passed	Repo-wide scan found no crypto/md5, crypto/des, crypto/rc4, SHA1-for-security, ECB, or ConstantTimeCompare/hmac.Equal uses; no CWE-327/CWE-208 issue.
No Injection Vectors	✅ Passed	No CWE-89/78/79/502 primitives in changed prod code: only Kind/string handling and safe URL assembly; no SQL, exec, template.HTML, or yaml.Unmarshal on untrusted input.
No Privileged Containers	✅ Passed	Dockerfile root use is justified and reverted; charts/tekton changes set non-root defaults and contain no privileged flags (CWE-250/CWE-732).
No Pii Or Sensitive Data In Logs	✅ Passed	No logging/print statements were added or changed in touched code; only Kind-field conversions and test expectations changed, so no CWE-532 log exposure risk.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

✨ Simplify code

• Create PR with simplified code

---

_{Comment @coderabbitai help to get the list of available commands.}

[hyperfleet-ci-bot]

Risk Score: 0 — risk/low

Signal	Detail	Points
PR size	162 lines	+0
Sensitive paths	none	+0
Test coverage	Tests cover changed packages	+0

_{Computed by hyperfleet-risk-scorer}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 23: The dependency bump to hyperfleet-api-spec v1.0.23 creates a
contract-drift risk with hyperfleet-sentinel, which still expects v1.0.12.
Update the Sentinel-side spec pin and any related compatibility checks in
lockstep with this change, or revert/block the go.mod bump until Sentinel is
updated to the same API spec version. Focus on the dependency entry in go.mod
and the corresponding Sentinel version reference.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1225861f-ec81-40c1-81c8-1c5d4739b54d

📥 Commits

Reviewing files that changed from the base of the PR and between da77f32 and 2b8308a.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum, !**/go.sum

📒 Files selected for processing (13)

• go.mod
• pkg/api/presenters/cluster.go
• pkg/api/presenters/cluster_test.go
• pkg/api/presenters/node_pool.go
• pkg/api/presenters/node_pool_test.go
• pkg/api/presenters/presenter_test.go
• pkg/api/presenters/resource.go
• pkg/api/presenters/resource_test.go
• pkg/handlers/cluster_nodepools_test.go
• pkg/handlers/validation_test.go
• test/integration/caller_identity_test.go
• test/integration/clusters_test.go
• test/integration/node_pools_test.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• openshift-hyperfleet/architecture (manual)
• openshift-hyperfleet/hyperfleet-api (manual)
• openshift-hyperfleet/hyperfleet-sentinel (manual)
• openshift-hyperfleet/hyperfleet-adapter (manual)
• openshift-hyperfleet/hyperfleet-broker (manual)

[coderabbitai]

🗄️ Data Integrity & Integration | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Inspect Sentinel's pinned spec and Kind handling assumptions.
gh api repos/openshift-hyperfleet/hyperfleet-sentinel/contents/go.mod \
  --jq '.content' | base64 -d | rg -n 'hyperfleet-api-spec'
gh search prs --repo openshift-hyperfleet/hyperfleet-sentinel --state open 'api-spec' --json title,number

Repository: openshift-hyperfleet/hyperfleet-api

Length of output: 301

---

Coordinate the spec bump with Sentinel. hyperfleet-api-spec moved to v1.0.23, but hyperfleet-sentinel still pins v1.0.12 and assumes a compatible API spec. That leaves a contract-drift risk; update Sentinel in lockstep or block this bump until it does.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 23, The dependency bump to hyperfleet-api-spec v1.0.23
creates a contract-drift risk with hyperfleet-sentinel, which still expects
v1.0.12. Update the Sentinel-side spec pin and any related compatibility checks
in lockstep with this change, or revert/block the go.mod bump until Sentinel is
updated to the same API spec version. Focus on the dependency entry in go.mod
and the corresponding Sentinel version reference.

Sources: Path instructions, Linked repositories

[rafabene]

Tip

nit — non-blocking suggestion

Category: Pattern

Removing the util import left a blank line that splits internal packages into two groups. Per import ordering convention, all internal packages should be in one group:

Suggested change

	"github.com/openshift-hyperfleet/hyperfleet-api/pkg/api/openapi"
	"github.com/openshift-hyperfleet/hyperfleet-api/pkg/util"
	"github.com/openshift-hyperfleet/hyperfleet-api/test"
	"github.com/openshift-hyperfleet/hyperfleet-api/pkg/api/openapi"
	"github.com/openshift-hyperfleet/hyperfleet-api/test"

[rafabene]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafabene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rafabene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment