(#1536) Refactor OpenSearchQueryRequest and move includes to builder#1937
Merged
Yury-Fridlyand merged 4 commits intoAug 9, 2023
Conversation
acarbonetto
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
…ludes to builder (#320) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto
force-pushed
the
integ-refactor-OpenSearchQueryRequest-includes-1536
branch
from
41944d4 to
33d0991
Compare
Codecov Report
@@ Coverage Diff @@
## main #1937 +/- ##
=========================================
Coverage 97.42% 97.42%
+ Complexity 4647 4646 -1
=========================================
Files 408 408
Lines 11526 11526
Branches 839 837 -2
=========================================
Hits 11229 11229
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matthewryanwells
approved these changes
Aug 4, 2023
Yury-Fridlyand
previously approved these changes
Aug 5, 2023
Contributor
|
Please run spotless apply. |
MitchellGale
approved these changes
Aug 8, 2023
MaxKsyunz
previously approved these changes
Aug 9, 2023
MaxKsyunz
reviewed
Aug 9, 2023
Collaborator
MaxKsyunz
left a comment
MaxKsyunz
left a comment
There was a problem hiding this comment.
Could looks good but CI is failing -- spotless check is failing.
…SearchQueryRequest-includes-1536 Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
acarbonetto
dismissed stale reviews from MaxKsyunz and Yury-Fridlyand
via
b39824b
…SearchQueryRequest-includes-1536 Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Yury-Fridlyand
approved these changes
Aug 9, 2023
GumpacG
approved these changes
Aug 9, 2023
Yury-Fridlyand
deleted the
integ-refactor-OpenSearchQueryRequest-includes-1536
branch
opensearch-trigger-bot Bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…1937) * #1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * #1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * #1536: Checkstyle fixes Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * #1536: Checkstyle fixes Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * #1536: Spotless Apply Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> (cherry picked from commit 7d23e0f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
GumpacG
pushed a commit
that referenced
this pull request
Aug 10, 2023
…1937) (#1948) * #1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * #1536: Refactor OpenSearchQueryRequest and move incldues to builder * #1536: Checkstyle fixes * #1536: Checkstyle fixes --------- * #1536: Spotless Apply --------- (cherry picked from commit 7d23e0f) Signed-off-by: acarbonetto <andrewc@bitquilltech.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 14, 2023
…cludes to builder (opensearch-project#1937) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> * opensearch-project#1536: Spotless Apply Signed-off-by: acarbonetto <andrewc@bitquilltech.com> --------- Signed-off-by: acarbonetto <andrewc@bitquilltech.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor OpenSearchScrollRequest and OpenSearchQueryRequest to check for includes list in the OpenSearchRequestBuilder so that the logic to create the list is consolidated.
Issues Resolved
Fixes #1536
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.