Update SHOW TABLES query.#48
Merged
Yury-Fridlyand merged 2 commits intoJun 14, 2023
Merged
Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
MaxKsyunz,
Swiddis,
YANG-DB,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
matthewryanwells
approved these changes
Jun 2, 2023
GumpacG
approved these changes
Jun 2, 2023
acarbonetto
approved these changes
Jun 2, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
6 tasks
forestmvey
approved these changes
Jun 7, 2023
forestmvey
reviewed
Jun 7, 2023
| query += table_valid | ||
| ? (search_pattern ? table_name : "^" + table_name + "$") | ||
| : "%"; | ||
| query += '\''; |
Collaborator
There was a problem hiding this comment.
It'd be nicer if you didn't mix n match different quote types in the function.
Collaborator
Author
There was a problem hiding this comment.
In terms of C++ performance, str + char is faster than str + str and consumes less memory.
matthewryanwells
approved these changes
Jun 7, 2023
MitchellGale
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SHOW TABLES LIKE %query was used to verify the connection. As of opensearch-project/sql#1181, query syntax changed in V2. This query was falling back to V1 SQL plugin engine, which would be deprecated once upon a time. Updating this query in ODBC driver ensures that SQL plugin would properly respond to it.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.