Move from Travis CI to github actions by akosveres · Pull Request #698 · openfaas/faas-netes

akosveres · 2020-11-04T19:09:17Z

Description

The pull request has the following changes:

github actions workflow following the travis ci build
update README with new github actions badge instead of the travis ci one
remove .travis.yaml
remove now unneeded bash script which sets travis ci experimental flag

Motivation and Context

I have raised an issue to propose this change (required)
It fixes GitHub Actions Migration - tracking issue faas#1585

How Has This Been Tested?

The workflow has been tested on my private fork, all steps have completed successfully, except the push to github container registry.

Link to latest build https://github.com/akosveres/faas-netes/runs/1354594029?check_suite_focus=true

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have signed-off my commits with git commit -s
I have added tests to cover my changes.
All new and existing tests passed.

Signed-off-by: Akos Veres <veres@akos.me>

akosveres · 2020-11-04T19:26:06Z

Additional question is: do we want to push images when tags get released? That would be new functionality and I was not sure if it's something we want to add now or as a separate PR?

alexellis · 2020-11-04T19:55:18Z

Yes definitely and that shouldn't be new behaviour as we do that now with Travis.

Signed-off-by: Akos Veres <veres@akos.me>

akosveres · 2020-11-04T20:41:46Z

More questions:

When do we want to push the latest tag? Maybe we need a separate flow for when merging in to master and only then pushing the latest tag and not during the PR.
Do we want to test the code during a tag push or would it be acceptable to just build the container and then push it to the registry?

Actions on the repository owners side to make this PR pass:

Enable github actions for the repository
Add docker secrets, we have to agree on the naming of the secrets.

alexellis · 2020-11-05T09:19:11Z

When do we want to push the latest tag? Maybe we need a separate flow for when merging in to master and only then pushing the latest tag and not during the PR.

Upon release tags along with the tag itself.

Do we want to test the code during a tag push or would it be acceptable to just build the container and then push it to the registry?

I think it is acceptable to only run e2e tests in a "ci-only" run (git push/PR) and to just release images in the "publish" job. This is the strategy I took with the example I shared on yesterday's call. https://github.com/alexellis/registry-creds/tree/master/.github/workflows

Actions on the repository owners side to make this PR pass:
Enable github actions for the repository
Add docker secrets, we have to agree on the naming of the secrets.

Will do 👍

alexellis · 2020-11-05T09:19:44Z

 ===========

-[![Build Status](https://travis-ci.com/openfaas/faas-netes.svg?branch=master)](https://travis-ci.com/openfaas/faas-netes)
+[![Build Status](https://github.com/openfaas/faas-netes/workflows/build/badge.svg?branch=master)](https://github.com/openfaas/faas-netes/actions)


Nice, I actually forgot about this.

@Waterdrips @LucasRoesler ☝️

alexellis · 2020-11-05T09:21:15Z

@@ -0,0 +1,69 @@
+name: publish


Let's call the file publish as per the reference examples.

alexellis · 2020-11-05T09:21:50Z

+        run: ./contrib/run_function.sh
+      - name: stop dev cluster
+        run: ./contrib/stop_dev.sh
+      - name: Sleep for 10 seconds


Can you do an inline GitHub script instead if a wait is needed? Third-party actions are disabled.

https://github.com/actions/github-script

alexellis · 2020-11-05T09:22:40Z

+      - name: deploy deploy
+        run: OPERATOR=0 ./contrib/deploy.sh
+      - name: run function
+        run: ./contrib/run_function.sh


Might be nice to OPERATOR=0 for consistency

alexellis · 2020-11-05T09:23:08Z

+        uses: docker/build-push-action@v2
+        with:
+          outputs: "type=registry,push=true"
+          platforms: linux/amd64,linux/arm/v6,linux/arm64


We can do arm/v7 for Docker images, arm/v6 for published binaries

alexellis · 2020-11-05T09:23:50Z

+      - name: Push containers
+        uses: docker/build-push-action@v2
+        with:
+          outputs: "type=registry,push=true"


I am conflicted about filling up the storage with images upon each commit into HEAD. Let's remove this for the time being.

If people want to try out solutions before their release via a tag, this might be beneficial. We could have a separate flow for pushing in to master for just this specifically, for the time being I'll remove the publishing of the images tho, as requested.

alexellis · 2020-11-05T09:24:08Z

+        run: ./contrib/lint_chart.sh
+      - name: create cluster
+        run: ./contrib/create_cluster.sh
+      - name: deploy deploy


Let's only run these tests during the "push" / "pr" events?

alexellis

Looks really good. Some comments were added for your input.

akosveres · 2020-11-05T18:02:21Z

I believe I fixed most of the issues in the comments, feel free to look at it again.

* Run function with OPERATOR=0 * Use github-script instead of custom wait-action * Remove push of container during CI run * Rename tag file to publish * Build armv7 images Signed-off-by: Akos Veres <veres@akos.me>

alexellis · 2020-11-06T15:24:22Z

+      - name: stop dev cluster
+        run: ./contrib/stop_dev.sh
+      - name: wait 10 seconds
+        run: sleep 10


Much better. I was thinking of this when out walking today.

alexellis

LGTM

This was missed in #698 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>

Move CI steps from travis to github actions

d6987b6

Signed-off-by: Akos Veres <veres@akos.me>

derek Bot added the new-contributor label Nov 4, 2020

Run github actions during pull request

185b2b4

Signed-off-by: Akos Veres <veres@akos.me>

Push container when tag pushed

8c6c848

Signed-off-by: Akos Veres <veres@akos.me>

alexellis reviewed Nov 5, 2020

View reviewed changes

alexellis requested changes Nov 5, 2020

View reviewed changes

Additional fixes based on comments

0ff922e

* Run function with OPERATOR=0 * Use github-script instead of custom wait-action * Remove push of container during CI run * Rename tag file to publish * Build armv7 images Signed-off-by: Akos Veres <veres@akos.me>

alexellis reviewed Nov 6, 2020

View reviewed changes

alexellis approved these changes Nov 6, 2020

View reviewed changes

alexellis merged commit bf7fb6d into openfaas:master Nov 6, 2020

alexellis mentioned this pull request Nov 6, 2020

Migrate builds from Travis to Github Actions openfaas/faas-cli#839

Merged

11 tasks

alexellis added a commit that referenced this pull request Nov 10, 2020

Add multi-arch build in Dockerfile

ae1b17a

This was missed in #698 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>

alexellis mentioned this pull request Nov 10, 2020

Add multi-arch build #705

Merged

alexellis added a commit that referenced this pull request Nov 10, 2020

Add multi-arch build in Dockerfile

807d981

This was missed in #698 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>

alexellis added a commit that referenced this pull request Nov 10, 2020

Add multi-arch build in Dockerfile

440374b

This was missed in #698 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>

alexellis mentioned this pull request Nov 11, 2020

Fix multiarch issues #708

Merged

Uh oh!

Conversation

akosveres commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

akosveres commented Nov 4, 2020

Uh oh!

alexellis commented Nov 4, 2020

Uh oh!

akosveres commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexellis commented Nov 5, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexellis left a comment

Choose a reason for hiding this comment

Uh oh!

akosveres commented Nov 5, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexellis left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

akosveres commented Nov 4, 2020 •

edited

Loading

akosveres commented Nov 4, 2020 •

edited

Loading