Document inferred SSO provider defaults - #435
Open
welteki wants to merge 1 commit into
Open
Conversation
Update the Google and Microsoft Entra SSO examples to omit authentication flags that are now inferred by the faas-cli. Document the automatic Google authority and grant defaults, the Entra localhost callback default, and the flags users can provide to override those values. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)9/10. The updates are focused, clear, and consistent with the stated provider-specific defaults, with no blocking issues found in the changed content. Summary per fileSummary per file
Overall AssessmentThe PR is safe to merge from a documentation review perspective. The edited sections improve the reader path by explaining which faas-cli values are inferred and by reducing command examples to the values users still need to provide. The examples remain consistent with the provider callback URLs described in each guide. Detailed ReviewDetailed ReviewContent reviewNo blocking findings.
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the Google and Microsoft Entra SSO pages to reflect provider-specific defaults inferred by the faas-cli.
The Google page documents the automatically selected authority and Implicit Id grant, along with the flags available to override those values. The example now only requires a Google client ID.
The Microsoft Entra page documents the automatic
http://localhostcallback address and the--redirect-hostoverride. The example no longer includes the inferred redirect-host flag.Motivation and Context
The faas-cli now infers common authentication values for Google and Microsoft Entra. The provider guides should show the simplified command-line experience while continuing to document the available flags and their default values.
How Has This Been Tested?
Reviewed the updated Markdown and verified the examples match the new faas-cli pro behavior.
Types of changes
Checklist:
git commit -s