Skip to content

Add generate option#672

Merged
liangchenye merged 9 commits intoopencontainers:masterfrom
zhouhao3:add-generate-option
Dec 14, 2018
Merged

Add generate option#672
liangchenye merged 9 commits intoopencontainers:masterfrom
zhouhao3:add-generate-option

Conversation

@zhouhao3
Copy link
Copy Markdown

Add the corresponding generate option according to the newly updated spec.

Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

Zhou Hao added 7 commits October 18, 2018 17:13
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Add vm-hypervisor-path option to specifies the path to the hypervisor binary that manages the container virtual machine.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Add vm-hypervisor-parameters option to specifies an array of parameters to pass to the hypervisor.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Add vm-kernel-path option to set path to the kernel used to boot the container virtual machine.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Add vm-kernel-parameters option to specifies an array of parameters to pass to the kernel.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Add vm-kernel-initrd to set path to an initial ramdisk to be used by the container virtual machine.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Add vm-image-path to set path to the container virtual machine root image.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
@zhouhao3 zhouhao3 force-pushed the add-generate-option branch 2 times, most recently from 087a6af to 6e297b5 Compare October 30, 2018 01:27
Add vm-image-format to set the format of the container virtual machine root image.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
@zhouhao3 zhouhao3 force-pushed the add-generate-option branch from 6e297b5 to 146c5ee Compare October 30, 2018 01:30
@zhouhao3
Copy link
Copy Markdown
Author

zhouhao3 commented Nov 5, 2018

This pr is a perfection of the generate function, and some verification will be done in the next pr.
@liangchenye @hqhq @vbatts @mrunalp PTAL.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
@zhouhao3
Copy link
Copy Markdown
Author

zhouhao3 commented Nov 6, 2018

A commit is added to verify the input value.
PTAL.

@liangchenye
Copy link
Copy Markdown
Member

liangchenye commented Dec 14, 2018

LGTM

seems security container (Kata for example) is now supported fully

Approved with PullApprove

@liangchenye liangchenye merged commit f81d4a8 into opencontainers:master Dec 14, 2018
@zhouhao3 zhouhao3 deleted the add-generate-option branch December 14, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants