Initialize Config Windows Network for Windows Namespace#666
Merged
zhouhao3 merged 1 commit intoopencontainers:masterfrom Oct 11, 2018
Merged
Initialize Config Windows Network for Windows Namespace#666zhouhao3 merged 1 commit intoopencontainers:masterfrom
zhouhao3 merged 1 commit intoopencontainers:masterfrom
Conversation
madhanrm
changed the title
Contributor
Author
|
@vbatts Can you provide some clue on how to fix the failing test? |
Contributor
|
@crosbymichael - Can you take a look at #667 and this one. Would be helpful for us to get these in to finish the CRI work. |
Contributor
Author
|
/retest |
|
Need rebase. |
Contributor
Author
|
@q384566678 can you take a look? |
zhouhao3
reviewed
Oct 10, 2018
Contributor
|
Nice! @madhanrm - Passed CI. |
Merged
Contributor
Author
|
@q384566678 Can you take a look? |
|
Please update the relevant instructions to |
Signed-off-by: Madhan Raj Mookkandy <madhanm@microsoft.com>
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize the windows network config during Network Namespace initialization
Signed-off-by: Madhan Raj Mookkandy madhanm@microsoft.com