validation: add more test cases for read-only paths tests#644
Merged
zhouhao3 merged 4 commits intoopencontainers:masterfrom Jun 25, 2018
Merged
Conversation
dongsupark
force-pushed
the
dongsu/test-readonly-paths
branch
from
784e7bc to
3e4cae6
Compare
zhouhao3
reviewed
Jun 7, 2018
validation/linux_readonly_paths.go
Outdated
| } | ||
|
|
||
| // Deliberately set a relative path to be read-only, and expect an error | ||
| readonlyRelPath := "/etc/../readonly-relpath" |
There was a problem hiding this comment.
Is it a relative path? I think it equal to /readonly-relpath. It's a absolute path.
Author
There was a problem hiding this comment.
@q384566678 Fixed the relative path.
Also fixed the same one in #643.
There was a problem hiding this comment.
Why not use readonlyRelPath := "readonly-relpath" ?
Split out the test function into `checkReadonlyPaths()`, and add more cases for readonly paths like subdirectory, file under subdirectory, and directory under subdirectory. Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
dongsupark
force-pushed
the
dongsu/test-readonly-paths
branch
from
3e4cae6 to
fc6aec7
Compare
added 3 commits
June 12, 2018 10:33
Test inside container should return error if a relative path is given for read-only paths. Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
Deliberately create an invalid read-only symlink that points out of the container, to see if the test fails inside the container. Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
Create read-only block device, char device, and fifo, to check if they are read-only as expected. Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
dongsupark
force-pushed
the
dongsu/test-readonly-paths
branch
from
fc6aec7 to
303ae30
Compare
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out the test function into
checkReadonlyPaths(), and add more cases for read-only paths like subdirectory, file under subdirectory, and directory under subdirectory.Test inside container should return error if a relative path is given for read-only paths.
Deliberately create an invalid read-only symlink that points out of the container, to see if the test fails inside the container.
Create read-only block device, char device, and fifo, to check if they are read-only as expected.