Skip to content

cgroups_v1: Correction parameters#629

Merged
liangchenye merged 1 commit intoopencontainers:masterfrom
zhouhao3:cgroups-v1-fix
May 9, 2018
Merged

cgroups_v1: Correction parameters#629
liangchenye merged 1 commit intoopencontainers:masterfrom
zhouhao3:cgroups-v1-fix

Conversation

@zhouhao3
Copy link
Copy Markdown

Instead of specifying the value, use the passed in parameter. (although they have the same value)

Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

Instead of specifying the value, use the passed in parameter. (although they have the same value)

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
@liangchenye
Copy link
Copy Markdown
Member

+1 for this.
I think we should remove RelCgroupPath in cgroups.go and add RelCgroupTestPath to validation/cgroup.go. This is just a testing variable.

@dongsupark
Copy link
Copy Markdown

+1. Looks good.

@liangchenye
Copy link
Copy Markdown
Member

liangchenye commented May 9, 2018

LGTM

Approved with PullApprove

@liangchenye liangchenye merged commit cac0a0d into opencontainers:master May 9, 2018
@zhouhao3 zhouhao3 deleted the cgroups-v1-fix branch May 10, 2018 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants