doc: add developer guidelines#621
Merged
zhouhao3 merged 1 commit intoopencontainers:masterfrom Apr 19, 2018
Merged
Conversation
wking
reviewed
Apr 17, 2018
Contributor
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
Two nits, otherwise this looks good to me.
docs/devel_guidelines.md
Outdated
|
|
||
| ### Exit status | ||
|
|
||
| When the runtime fails a test, the TAP output indicates so with "not ok" but the exit status of test program normally remain 0. |
docs/devel_guidelines.md
Outdated
|
|
||
| When the runtime fails a test, the TAP output indicates so with "not ok" but the exit status of test program normally remain 0. | ||
| A non-zero exit status indicates a problem in the test program rather than in the runtime. | ||
|
|
Contributor
There was a problem hiding this comment.
No need for this trailing empty line.
It's not obvious how the TAP output is displayed and the meaning of the exit value. This documentation is meant to be for developers who want to add a new validation test. Signed-off-by: Alban Crequy <alban@kinvolk.io>
alban
force-pushed
the
alban/devel_guidelines
branch
from
1e5556b to
cc8ab2e
Compare
Contributor
Author
|
@wking thanks for the review! I updated the commit. |
wking
approved these changes
Apr 17, 2018
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not obvious how the TAP output is displayed and the meaning of the
exit value.
This documentation is meant to be for developers who want to add a new
validation test.
Signed-off-by: Alban Crequy alban@kinvolk.io