Skip to content

validation: add process_user validation#611

Merged
liangchenye merged 1 commit intoopencontainers:masterfrom
zhouhao3:process-user
Mar 21, 2018
Merged

validation: add process_user validation#611
liangchenye merged 1 commit intoopencontainers:masterfrom
zhouhao3:process-user

Conversation

@zhouhao3
Copy link
Copy Markdown

Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
@liangchenye
Copy link
Copy Markdown
Member

liangchenye commented Mar 21, 2018

LGTM

Approved with PullApprove

@liangchenye liangchenye merged commit 3322c45 into opencontainers:master Mar 21, 2018
@zhouhao3 zhouhao3 deleted the process-user branch March 21, 2018 02:47
g := util.GetDefaultGenerator()
g.SetProcessUID(10)
g.SetProcessGID(10)
g.AddProcessAdditionalGid(5)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this switch on runtime.GOOS or an environment variable or flag for adding username instead?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed it in #614.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants