Skip to content

Fix condition in BlockIO test#595

Merged
zhouhao3 merged 1 commit intoopencontainers:masterfrom
kinvolk-archives:alban/blkio-leafWeight
Mar 9, 2018
Merged

Fix condition in BlockIO test#595
zhouhao3 merged 1 commit intoopencontainers:masterfrom
kinvolk-archives:alban/blkio-leafWeight

Conversation

@alban
Copy link
Copy Markdown
Contributor

@alban alban commented Mar 8, 2018

Symptoms:

$ sudo validation/linux_cgroups_relative_blkio.t

 not ok 6 - blkio leafWeight for 8:0 is set correctly
 # expect: 300, actual: 300

After the patch:

 ok 6 - blkio leafWeight for 8:0 is set correctly
 # expect: 300, actual: 300

Signed-off-by: Alban Crequy alban@kinvolk.io

Symptoms:
```
$ sudo validation/linux_cgroups_relative_blkio.t

 not ok 6 - blkio leafWeight for 8:0 is set correctly
 # expect: 300, actual: 300
```

After the patch:
```
 ok 6 - blkio leafWeight for 8:0 is set correctly
 # expect: 300, actual: 300
```

Signed-off-by: Alban Crequy <alban@kinvolk.io>
Copy link
Copy Markdown
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :). Sorry about the typo (it was me in #542).

@zhouhao3
Copy link
Copy Markdown

zhouhao3 commented Mar 9, 2018

LGTM

Approved with PullApprove

@zhouhao3 zhouhao3 merged commit 333d05d into opencontainers:master Mar 9, 2018
@alban alban deleted the alban/blkio-leafWeight branch March 12, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants