add annotation and prop tests by liangchenye · Pull Request #586 · opencontainers/runtime-tools

liangchenye · 2018-02-28T13:47:48Z

test cases for AnnotationsKeyReversedDomain, AnnotationsKeyReservedNS,
AnnotationsKeyIgnoreUnknown, ExtensibilityIgnoreUnknownProp and
ValidValues

Signed-off-by: Liang Chenye liangchenye@huawei.com

liangchenye · 2018-02-28T13:50:48Z

add a random key to test 'AnnotationsKeyIgnoreUnknown'
add an 'Unknown' proper to config.json to test 'ExtensibilityIgnoreUnknownProp'
using invalid version to test 'ValidValues'
but seems runc does not popup errors.

liangchenye · 2018-03-06T06:25:13Z

rebased, PTAL @q384566678

zhouhao3 · 2018-03-06T08:35:35Z

validation/misc_props.go

+			PreCreate: func(r *util.Runtime) error {
+				r.SetID(containerID)
+				saveConfig(configFile, c.eSpec)
+				return nil


I think it's better to return saveConfig(configFile, c.eSpec)

I'll update it.

zhouhao3 · 2018-03-06T08:38:55Z

It was in a panic when I was testing. Here is the test. I'm looking for the reason.

➜  runtime-tools git:(4826ab8) ✗ ./oci-runtime-tool validate
key  SHOULD be named using a reverse domain notation
Refer to: https://github.com/opencontainers/runtime-spec/blob/v1.0.0/config.md#annotations
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x575f02]

goroutine 1 [running]:
github.com/opencontainers/runtime-tools/vendor/github.com/hashicorp/go-multierror.(*Error).Error(0x0, 0x9eaea0, 0x0)
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/vendor/github.com/hashicorp/go-multierror/multierror.go:15 +0x22
github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli.HandleExitCoder(0x9eaea0, 0x0)
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli/errors.go:102 +0xff
github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli.Command.Run(0x801238, 0x8, 0x0, 0x0, 0x0, 0x0, 0x0, 0x807013, 0x16, 0x0, ...)
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli/command.go:196 +0xadc
github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli.(*App).Run(0xc420086b60, 0xc42000c080, 0x2, 0x2, 0x0, 0x0)
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli/app.go:250 +0x758
main.main()
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/cmd/oci-runtime-tool/main.go:50 +0x404

Add test cases for test cases for AnnotationsKeyReversedDomain, AnnotationsKeyReservedNS, AnnotationsKeyIgnoreUnknown, ValidValues and ExtensibilityIgnoreUnknownProp. Signed-off-by: Liang Chenye <liangchenye@huawei.com>

liangchenye · 2018-03-06T08:53:38Z

@q384566678 it works in my test, can you post your 'config.json' file?

zhouhao3 · 2018-03-06T08:59:15Z

{
        "ociVersion": "1.0.0",
        "process": {
                "user": {
                        "uid": 0,
                        "gid": 0
                },
                "args": [
                        "sh"
                ],
                "env": [
                        "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                        "TERM=xterm"
                ],
                "cwd": "/"
        },
        "root": {
                "path": "rootfs"
        },
        "linux": {
                "resources": {
                        "devices": [
                                {
                                        "allow": false,
                                        "access": "rwm"
                                }
                        ]
                }
        },
        "annotations": {
                    "test": "22"
        }
}

liangchenye · 2018-03-06T09:04:17Z

@q384566678 thanks, I can reproduce it. Debugging now.

liangchenye · 2018-03-06T10:17:34Z

Very strange, if I add the following useless lines, it works. I'll continue to debug it tomorrow.

			if levelErrors.Error == nil {
				return nil
			}
 			return levelErrors.Error

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

liangchenye · 2018-03-09T10:55:54Z

The original code return *error instread of error. The new commit solves that.
It is more accurate to return levelErrors.Error.ErrorOrNil(). It works in my test.
PTAL @q384566678

zhouhao3 · 2018-03-12T02:56:14Z

validation/misc_props.go

+
+	type extendedSpec struct {
+		rspecs.Spec
+		Unknown string `json:"unknown,omitempty"`


I don't quite understand what that does.

I use this to test ’runtimes that are reading or processing this configuration file MUST NOT generate an error if they encounter an unknown property‘. 'Unknown' here (in my commit) means the 'unknown property', so when a runtime reads this, it does not know what it means and it should not generete an error.

zhouhao3 · 2018-03-12T05:32:40Z

LGTM

alban · 2018-07-19T15:04:34Z

using invalid version to test 'ValidValues' but seems runc does not popup errors.

I filed an issue about this: opencontainers/runc#1846

liangchenye force-pushed the annotation branch from 49766a4 to 4826ab8 Compare March 5, 2018 12:04

zhouhao3 reviewed Mar 6, 2018

View reviewed changes

add annotation and prop tests

4e8dc67

Add test cases for test cases for AnnotationsKeyReversedDomain, AnnotationsKeyReservedNS, AnnotationsKeyIgnoreUnknown, ValidValues and ExtensibilityIgnoreUnknownProp. Signed-off-by: Liang Chenye <liangchenye@huawei.com>

liangchenye force-pushed the annotation branch from 4826ab8 to 375055d Compare March 6, 2018 10:13

liangchenye changed the title ~~add annotation and prop tests~~ WIP: add annotation and prop tests Mar 6, 2018

liangchenye force-pushed the annotation branch from 375055d to 7a47053 Compare March 6, 2018 10:16

return ErrorOrNil in bundle validate

e43d1ff

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

liangchenye force-pushed the annotation branch from 7a47053 to ad226bc Compare March 9, 2018 10:43

liangchenye changed the title ~~WIP: add annotation and prop tests~~ add annotation and prop tests Mar 9, 2018

liangchenye force-pushed the annotation branch from ad226bc to e43d1ff Compare March 9, 2018 10:44

zhouhao3 reviewed Mar 12, 2018

View reviewed changes

zhouhao3 merged commit 3a83c2c into opencontainers:master Mar 12, 2018

alban mentioned this pull request Jul 19, 2018

runc does not error on ociVersion=invalid opencontainers/runc#1846

Open

Conversation

liangchenye commented Feb 28, 2018

Uh oh!

liangchenye commented Feb 28, 2018

Uh oh!

liangchenye commented Mar 6, 2018

Uh oh!

zhouhao3 Mar 6, 2018

Choose a reason for hiding this comment

Uh oh!

liangchenye Mar 6, 2018

Choose a reason for hiding this comment

Uh oh!

zhouhao3 commented Mar 6, 2018

Uh oh!

liangchenye commented Mar 6, 2018

Uh oh!

zhouhao3 commented Mar 6, 2018

Uh oh!

liangchenye commented Mar 6, 2018

Uh oh!

liangchenye commented Mar 6, 2018

Uh oh!

liangchenye commented Mar 9, 2018

Uh oh!

zhouhao3 Mar 12, 2018

Choose a reason for hiding this comment

Uh oh!

liangchenye Mar 12, 2018

Choose a reason for hiding this comment

Uh oh!

zhouhao3 commented Mar 12, 2018 • edited by caniszczyk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alban commented Jul 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zhouhao3 commented Mar 12, 2018 •

edited by caniszczyk

Loading