don't overwrite hook which has a same path#571
Merged
zhouhao3 merged 1 commit intoopencontainers:masterfrom Feb 7, 2018
Merged
don't overwrite hook which has a same path#571zhouhao3 merged 1 commit intoopencontainers:masterfrom
zhouhao3 merged 1 commit intoopencontainers:masterfrom
Conversation
Signed-off-by: Liang Chenye <liangchenye@huawei.com>
Member
Author
|
The issue is found in #569. For history reason, we add a hook and add hook env separately, so the 'path' is the unique ID to add env correctly. Now we are adding a full hook with json format, so we don't need to have this limitation. |
Member
Author
|
PTAL @q384566678 @Mashimiao |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liang Chenye liangchenye@huawei.com