Skip to content

Relax LGTM requirement#559

Merged
zhouhao3 merged 1 commit intomasterfrom
relax-pullapprove
Feb 1, 2018
Merged

Relax LGTM requirement#559
zhouhao3 merged 1 commit intomasterfrom
relax-pullapprove

Conversation

@caniszczyk
Copy link
Copy Markdown
Contributor

There has been a request to relax the number of LGTMs in the tools projects to help improve merge rate.

Signed-off-by: Chris Aniszczyk caniszczyk@gmail.com

There has been a request to relax the number of LGTMs in the
tools projects to help improve merge rate.

Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
@wking
Copy link
Copy Markdown
Contributor

wking commented Jan 23, 2018

Should this also come with a MAINTAINERS prune? I'm surprised that a project with 11 active maintainers would have difficulty collecting two LGTMs, so if we are having trouble with that, then all 11 maintainers are probably not active.

@wking
Copy link
Copy Markdown
Contributor

wking commented Jan 23, 2018

And if we go with one LGTM, you'll also want to update the maintainer's guide.

@liangchenye
Copy link
Copy Markdown
Member

@caniszczyk Hi, can you update the 'MAINTAINERS_GUIDE.md' ?

@liangchenye
Copy link
Copy Markdown
Member

liangchenye commented Feb 1, 2018

LGTM
I think we can merge it first, I'll update the maintainer's guide later.

Approved with PullApprove

@zhouhao3
Copy link
Copy Markdown

zhouhao3 commented Feb 1, 2018

LGTM

Approved with PullApprove

@zhouhao3 zhouhao3 merged commit 74f2659 into master Feb 1, 2018
@wking
Copy link
Copy Markdown
Contributor

wking commented Feb 1, 2018

Should this also come with a MAINTAINERS prune?

I haven't noticed difficulty collecting two LGTMs, but there are certainly a few nominal maintainers that LGTM pulls very rarely. On the other hand, free-riding non-spec maintainers aren't much of a functional issue.

@liangchenye
Copy link
Copy Markdown
Member

I think the change is about: the strategy of the tool project could be 'more agile and mistake tolerable' .

@tianon tianon deleted the relax-pullapprove branch March 26, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants