cmd/runtimetest/main: Run validateDefaultDevices even with process unset#553
Merged
zhouhao3 merged 1 commit intoopencontainers:masterfrom Feb 2, 2018
Merged
Conversation
6d2dbbc (runtimetest: fix nil deference, 2017-10-11, opencontainers#494) put the nil-Process guard in, but it was a bit too coarse. We can still run these tests with a nil Process, because all we need Process for is deciding whether or not to include /dev/console. Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM |
Contributor
Author
|
Closing and reopening to kick Travis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6d2dbbc (#494) put the nil-
Processguard in, but it was a bit too coarse. We can still run these tests with a nilProcess, because all we needProcessfor is deciding whether or not to include/dev/console.