validate_test: add test func#537
Merged
Mashimiao merged 2 commits intoopencontainers:masterfrom Dec 13, 2017
Merged
Conversation
added 2 commits
December 8, 2017 09:55
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
wking
reviewed
Dec 8, 2017
| }, | ||
| } | ||
| for _, c := range cases { | ||
| v := NewValidator(&c.val, ".", false, "linux") |
Contributor
There was a problem hiding this comment.
Do we want a test to demonstrate that Hooks is ignored on Windows?
Author
There was a problem hiding this comment.
We can add it later because the corresponding verification code is not perfect yet.
Contributor
There was a problem hiding this comment.
We can add it later because the corresponding verification code is not perfect yet.
Ah right, it is blocked on #538.
wking
approved these changes
Dec 11, 2017
Member
|
LGTM |
1 similar comment
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some waiting improvements for the validation of the
mounts, and the test function can be added later.Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com