Skip to content

generator solaris application container configuration#532

Merged
Mashimiao merged 7 commits intoopencontainers:masterfrom
zhouhao3:generate-solaris
Dec 19, 2017
Merged

generator solaris application container configuration#532
Mashimiao merged 7 commits intoopencontainers:masterfrom
zhouhao3:generate-solaris

Conversation

@zhouhao3
Copy link
Copy Markdown

@zhouhao3 zhouhao3 commented Dec 2, 2017

Add some options to generate solaris application container configuration

Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

@Mashimiao
Copy link
Copy Markdown

Mashimiao commented Dec 4, 2017

LGTM

Approved with PullApprove

@zhouhao3
Copy link
Copy Markdown
Author

@liangchenye Do you think that's ok? If this and #528 can be merged, we have perfected all the generate functions.

Zhou Hao added 7 commits December 18, 2017 10:00
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
@zhouhao3
Copy link
Copy Markdown
Author

@liangchenye @mrunalp PTAL

@liangchenye
Copy link
Copy Markdown
Member

liangchenye commented Dec 18, 2017

LGTM

Approved with PullApprove

1 similar comment
@Mashimiao
Copy link
Copy Markdown

Mashimiao commented Dec 19, 2017

LGTM

Approved with PullApprove

@Mashimiao Mashimiao merged commit 9c39ab5 into opencontainers:master Dec 19, 2017
@zhouhao3 zhouhao3 deleted the generate-solaris branch December 20, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants