complete specerror of config-linux.md config-windows.md#497
Merged
zhouhao3 merged 1 commit intoopencontainers:masterfrom Oct 25, 2017
Merged
complete specerror of config-linux.md config-windows.md#497zhouhao3 merged 1 commit intoopencontainers:masterfrom
zhouhao3 merged 1 commit intoopencontainers:masterfrom
Conversation
Signed-off-by: Liang Chenye <liangchenye@huawei.com>
Member
Author
|
Too many RFC codes to translate so |
|
LGTM If there are not any vital errors, I think we can let this in. If we found any error when taking advantage of them, we can fix other PRs. |
|
LGTM |
wking
reviewed
Oct 25, 2017
| // NSInheritWithoutType represents "If a namespace type is not specified in the `namespaces` array, the container MUST inherit the runtime namespace of that type." | ||
| NSInheritWithoutType = "If a namespace type is not specified in the `namespaces` array, the container MUST inherit the runtime namespace of that type." | ||
| // NSErrorOnDup represents "If a `namespaces` field contains duplicated namespaces with same `type`, the runtime MUST generate an error." | ||
| NSErrorOnDup = "If a `namespaces` field contains duplicated namespaces with same `type`, the runtime MUST generate an error." |
Contributor
There was a problem hiding this comment.
This is an odd one, because we allow runtimes to skip validation, but I guess not here. And we have similar wording for rlimits. But neither of those are worded quite right for a non-runtime validator like our validate, and it feels odd to force runtimes to error on these but allow them to handle all sorts of other broken configurations. Maybe not worth holding up this PR, but I'll file a spec PR trying to clean this up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liang Chenye liangchenye@huawei.com