Skip to content

cmd: modify the err judgment#462

Merged
mrunalp merged 1 commit intoopencontainers:masterfrom
zhouhao3:checkerr-fix
Sep 9, 2017
Merged

cmd: modify the err judgment#462
mrunalp merged 1 commit intoopencontainers:masterfrom
zhouhao3:checkerr-fix

Conversation

@zhouhao3
Copy link
Copy Markdown

@zhouhao3 zhouhao3 commented Sep 5, 2017

Modify the following error situation:

✗ oci-runtime-tool validate 
0 errors occurred:


Signed-off-by: zhouhao zhouhao@cn.fujitsu.com

@Mashimiao
Copy link
Copy Markdown

This is really not a good fix...., you'd better fix take advantage of multierror to fix this in CheckAll()

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
@zhouhao3
Copy link
Copy Markdown
Author

zhouhao3 commented Sep 7, 2017

updated, PTAL.

@Mashimiao
Copy link
Copy Markdown

Mashimiao commented Sep 7, 2017

LGTM

Approved with PullApprove

1 similar comment
@mrunalp
Copy link
Copy Markdown
Contributor

mrunalp commented Sep 9, 2017

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit d09d81a into opencontainers:master Sep 9, 2017
@zhouhao3 zhouhao3 deleted the checkerr-fix branch September 10, 2017 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants