generate: support adding additional mounts for container#279
Merged
liangchenye merged 3 commits intoopencontainers:masterfrom Nov 29, 2017
Merged
Conversation
Mashimiao
force-pushed
the
generate-add-mounts-add-option
branch
from
49e0dd5 to
902366d
Compare
Mashimiao
force-pushed
the
generate-add-mounts-add-option
branch
from
902366d to
88aecac
Compare
Author
|
Rebased. @opencontainers/runtime-tools-maintainers PTAL |
Mashimiao
force-pushed
the
generate-add-mounts-add-option
branch
from
88aecac to
47f3dc0
Compare
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
zhouhao3
reviewed
Nov 24, 2017
cmd/oci-runtime-tool/generate.go
Outdated
| default: | ||
| return source, dest, mType, options, fmt.Errorf("--mounts-add should have format src:dest:type:[:options...]") | ||
| } | ||
|
|
There was a problem hiding this comment.
The non-null verification of dest should be increased because it is required.
Mashimiao
force-pushed
the
generate-add-mounts-add-option
branch
2 times, most recently
from
3b72950 to
74d6245
Compare
added 2 commits
November 28, 2017 17:15
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
|
LGTM |
Member
|
decoupled with #439, I'll merge it. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for adding additional mounts.
Users can add custom additional mounts, like adding tmpfs without special options or with custom options.