Skip to content

[Config Linux] Replace "required" (lower case) #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RobDolinMS wants to merge 1 commit into from
Closed

[Config Linux] Replace "required" (lower case) #729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config-linux.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ You can configure a container's cgroups via the `resources` field of the Linux c
Do not specify `resources` unless limits have to be updated.
For example, to run a new process in an existing container without updating limits, `resources` need not be specified.

A runtime MUST at least use the minimum set of cgroup controllers required to fulfill the `resources` settings.
A runtime MUST at least use the minimum set of cgroup controllers necessary to fulfill the `resources` settings.
However, a runtime MAY attach the container process to additional cgroup controllers supported by the system.
Copy link
Copy Markdown
Contributor

@wking wking Mar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even want to keep the line you're bumping? It sounds like any runtime which violated that constraint would necessarily violate some more specific constraint on a resources setting. Maybe replace this paragraph with:

Runtimes MAY attach the container process to additional cgroup controllers beyond those required to fulfill the resources settings.


###### Example
Expand Down