runtime: Add 'exit' to state for collecting the container exit code#677
Closed
wking wants to merge 1 commit intoopencontainers:masterfrom
Closed
runtime: Add 'exit' to state for collecting the container exit code#677wking wants to merge 1 commit intoopencontainers:masterfrom
wking wants to merge 1 commit intoopencontainers:masterfrom
Conversation
This gives us a more portable way to discover the container exit code (vs. requiring callers to use subreapers [1] or other platform-specific approaches which require knowledge of the runtime implementation). [1]: opencontainers/runc#827 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Member
|
You cannot have this as required because that forces the runtime to always be running to update the state files. This change just forces long running runtimes and will impact performance and usage down the road when you run at scale. If you leave the runtime running it returns the container's exit status as its exit status anyway if you make that tradeoff. This does not belong in the spec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives us a more portable way to discover the container exit code (vs. requiring callers to use subreapers or other platform-specific approaches which require knowledge of the runtime implementation).
There would still be no portable way to discover when the container had exited (short of polling
state), but we can handle that separately.