Makefile: comment on seemingly unused variable

[vbatts]

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

[wking]

SHELL was added in f3fdf03 (Makefile: prefer bash, 2016-05-25, #455)
referencing #454. I am in favor of a Makefile that only needs a POSIX
shell, but I'd like to understand any POSIX-shell-incompatibilities.
I would have preferred to have that information before we added the
variable 1, but I guess I'm ok removing it, waiting for someone to
reopen #454, and then collecting that information before re-adding
SHELL (or ideally, fixing the POSIX-shell-incompatible command).

[vbatts]

Oh oh oh
This commit should instead be.... A comment

On Fri, Aug 19, 2016, 12:25 W. Trevor King notifications@github.com wrote:

SHELL was added in f3fdf03 (Makefile: prefer bash, 2016-05-25, #455)
referencing #454. I am in favor of a Makefile that only needs a POSIX
shell, but I'd like to understand any POSIX-shell-incompatibilities.
I would have preferred to have that information before we added the
variable 1, but I guess I'm ok removing it, waiting for someone to
reopen #454, and then collecting that information before re-adding
SHELL (or ideally, fixing the POSIX-shell-incompatible command).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#534 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6fuOapqs7JJfkqy0sbThY2U8MYvQks5qhdkBgaJpZM4JolHR
.

[vbatts]

updated PTAL

[wking]

I'd rather just fix the POSIX-compatiblity issue, instead of working around it. Fix filed in #542.