Implement setns for cgroupns by path#1763
Closed
alban wants to merge 1 commit intoopencontainers:masterfrom
Closed
Implement setns for cgroupns by path#1763alban wants to merge 1 commit intoopencontainers:masterfrom
alban wants to merge 1 commit intoopencontainers:masterfrom
Conversation
The OCI runtime spec allows to specify a cgroupns path to enter: https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md#namespaces Example: "namespaces": [ { "type": "cgroup", "path": "/proc/1234/ns/cgroup" }, Signed-off-by: Alban Crequy <alban@kinvolk.io>
5 tasks
Member
|
Thanks for this, but we're already working on it as part of #1184 (which I'm working on carrying at the moment). In short (you can read the discussion in the thread), the "simple" way of implementing cgroup namespaces doesn't work as you'd expect because you will end up with having the root of the cgroup namespace being the cgroup the process was in before I'm closing this as a dup of #1184 (and I am going to carry it in the near future). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OCI runtime spec allows to specify a cgroupns path to enter:
https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md#namespaces
Example:
Signed-off-by: Alban Crequy alban@kinvolk.io
Issue found while trying to implement a test for this:
opencontainers/runtime-tools#572 (comment)