Modify the ref information by zhouhao3 · Pull Request #89 · opencontainers/image-tools

zhouhao3 · 2016-11-28T06:53:56Z

According to some norms can be seen, ref can also point to the manifest list, here only to modify some of the error message, some code error will continue to update in #51 .

I think it's more appropriate to change ref to tag.

Signed-off-by: zhouhao zhouhao@cn.fujitsu.com

coolljt0725 · 2016-11-28T07:50:38Z

 	}

-	if err = ref.validate(w, validRefMediaTypes); err != nil {
+	if err = ref.validate(w, []string{v1.MediaTypeImageManifest}); err != nil {


the ref could refer to manifest or manifest list, I don't think we need this change.

But in this place must be manifest

I don't think so. If the ref of an OCI image refer to a manifest list, and the the manifest list refer to a manifest, the findManifest below are supposed to get the manifest from the manifest list(the pr #51 your are woking on are doing this). With your changes, this process are break.

manifest list points to only a few special manifests, just specify its platform, there is no other property requirements. I do not think this is what you want to get, and in the instructions, ref can only point to the manifest.

In the pr #51 ,Only in the validation function need to confirm the manifest and manifestlist, and I just change the unpack and create-runtime-bundel function

manifest list points to only a few special manifests, just specify its platform, there is no other property

I don't know if you understand the manifest list correctly :). How could you unpack a OCI image if the ref( for more information about ref https://github.com/opencontainers/image-spec/blob/master/image-layout.md) points to manifest list ? and how do you know the ref is always point to a manifest ?

You are right, I was misled by some wrong information, and now I have this information modified.

coolljt0725 · 2016-11-29T09:08:52Z

@q384566678 image-tool can't handle manifest list at the moment, let's waiting the image-tool for adding this function and then let's has these changes in this pr, WDYT?

zhouhao3 · 2016-11-29T09:25:19Z

let's waiting the image-tool for adding this function and then let's has these changes in this pr, WDYT?

I increase the corresponding function in the pr #51 , because of some rely on pr #51 function, so can't update in the pr.

zhouhao3 · 2017-01-12T06:38:03Z

@xiekeyang @coolljt0725 @vbatts @stevvooe PTAL

coolljt0725 · 2017-02-07T03:28:33Z

let's make the image-tool can handle manifest list first then update the docs. close at the moment and will reopen once the image-tool can handle manifest list

zhouhao3 · 2017-07-20T05:24:24Z

Since the verification of the index has been improved in #51 , so I reopen this.

Mashimiao · 2017-07-21T06:51:50Z


 **--ref**=""
-  The ref pointing to the manifest of the OCI image. This must be present in the "refs" subdirectory of the image. (default "v1.0")
+  The ref pointing to the manifest or the image index of the OCI image. This must be present in the "refs" subdirectory of the image. (default "v1.0")


I think refs directory does not exist any more according to the spec

updated. And I think it's more appropriate to change ref to tag.

Mashimiao · 2017-07-21T07:46:48Z

-**--ref**=""
-  The ref pointing to the manifest of the OCI image. This must be present in the "refs" subdirectory of the image. (default "v1.0")
+**--tag**=""
+  The tag pointing to the manifest or the image index of the OCI image. his must be matching 'org.opencontainers.image.ref.name' annotations in index.json. (default "v1.0")


The spec always uses ref, and I prefer to ref. And ref must be pointing to a manifest, will not be an image index, we can get the manifest via image index. So I think the change is not correct.

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>

zhouhao3 · 2018-01-24T05:42:57Z

Because #169 has been merged, so close this pr.

coolljt0725 reviewed Nov 28, 2016

View reviewed changes

zhouhao3 force-pushed the ref-validate branch from 72a68e8 to b5e4955 Compare November 29, 2016 06:35

zhouhao3 changed the title ~~image.go:Modify the ref validation range~~ image.go:Modify the ref regulatory information Nov 29, 2016

zhouhao3 force-pushed the ref-validate branch from b5e4955 to 3121811 Compare November 29, 2016 07:05

coolljt0725 closed this Feb 7, 2017

xiekeyang mentioned this pull request Feb 16, 2017

Bump version for v0.1.0 #116

Merged

zhouhao3 reopened this Jul 20, 2017

zhouhao3 force-pushed the ref-validate branch 3 times, most recently from c9ccc11 to 18ea452 Compare July 20, 2017 05:40

zhouhao3 changed the title ~~image.go:Modify the ref regulatory information~~ man: Modify the ref information Jul 20, 2017

zhouhao3 force-pushed the ref-validate branch from 18ea452 to 896219c Compare July 20, 2017 05:56

Mashimiao reviewed Jul 21, 2017

View reviewed changes

zhouhao3 force-pushed the ref-validate branch 3 times, most recently from 91a3531 to 02c6e21 Compare July 21, 2017 07:31

zhouhao3 changed the title ~~man: Modify the ref information~~ change ref option to tag Jul 21, 2017

zhouhao3 changed the title ~~change ref option to tag~~ change ref option to tag and fix info Jul 21, 2017

zhouhao3 force-pushed the ref-validate branch from 02c6e21 to 1a1c4df Compare July 21, 2017 07:44

Mashimiao reviewed Jul 21, 2017

View reviewed changes

zhouhao3 force-pushed the ref-validate branch from 1a1c4df to 8e173ee Compare July 21, 2017 08:02

zhouhao3 changed the title ~~change ref option to tag and fix info~~ Modify the ref information Jul 21, 2017

Modify the ref information

afa6f23

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>

zhouhao3 force-pushed the ref-validate branch from 8e173ee to afa6f23 Compare July 21, 2017 08:07

Mashimiao mentioned this pull request Aug 4, 2017

Modify the ref option #169

Merged

zhouhao3 closed this Jan 24, 2018

zhouhao3 deleted the ref-validate branch January 24, 2018 05:43

Conversation

zhouhao3 commented Nov 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coolljt0725 Nov 28, 2016

Choose a reason for hiding this comment

Uh oh!

zhouhao3 Nov 28, 2016

Choose a reason for hiding this comment

Uh oh!

coolljt0725 Nov 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhouhao3 Nov 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhouhao3 Nov 29, 2016

Choose a reason for hiding this comment

Uh oh!

coolljt0725 Nov 29, 2016

Choose a reason for hiding this comment

Uh oh!

zhouhao3 Nov 29, 2016

Choose a reason for hiding this comment

Uh oh!

coolljt0725 commented Nov 29, 2016

Uh oh!

zhouhao3 commented Nov 29, 2016

Uh oh!

zhouhao3 commented Jan 12, 2017

Uh oh!

coolljt0725 commented Feb 7, 2017

Uh oh!

zhouhao3 commented Jul 20, 2017

Uh oh!

Mashimiao Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

zhouhao3 Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

Mashimiao Jul 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhouhao3 commented Jan 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zhouhao3 commented Nov 28, 2016 •

edited

Loading

coolljt0725 Nov 28, 2016 •

edited

Loading

zhouhao3 Nov 28, 2016 •

edited

Loading

Mashimiao Jul 21, 2017 •

edited

Loading