Skip to content

Fixing tls_authentication_over_grpc_test for Arista#5273

Merged
ram-mac merged 8 commits intoopenconfig:mainfrom
ram-mac:tls_auth_over_grpc_arista
Apr 1, 2026
Merged

Fixing tls_authentication_over_grpc_test for Arista#5273
ram-mac merged 8 commits intoopenconfig:mainfrom
ram-mac:tls_auth_over_grpc_arista

Conversation

@ram-mac
Copy link
Copy Markdown
Contributor

@ram-mac ram-mac commented Mar 28, 2026

Following changes were done for Arista, Juniper and Cisco
1.Arista-specific user creation in the createNativeUser function. It now uses a native EOS CLI command to create the user with privilege 15 and the network-admin role, which is required for gNMI configuration operations.
2.Juniper specifc user creation was added to the function as it is required. Otherwise the SSH authentication would fail. However, juniper still fails for metadata authentication. It will be fixed in another PR.
3.Cleanup the test after the run is over. After changing the hostname via gnmi.set, the test was not reverted back to original form. So added a defer function
4.Cisco does not support the gnmi.replace for system/hostname, so have added the code to handle the defer function accordingly.

@ram-mac ram-mac requested a review from a team as a code owner March 28, 2026 02:13
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for Arista devices within the TLS authentication over gRPC test suite. It modifies the user creation logic to utilize native EOS CLI commands, ensuring that users are correctly provisioned with the necessary privileges and roles required for gNMI configuration operations.

Highlights

  • Arista Platform Support: Added a specific case for Arista devices in the createNativeUser function to handle user creation via CLI.
  • Metadata Update: Updated the test metadata to include ARISTA as a platform exception for the set_native_user deviation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Mar 28, 2026

Pull Request Functional Test Report for #5273 / cbb7193

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
SEC-3.1: Authentication
92670f4d Log
Cisco 8000E status
SEC-3.1: Authentication
860c7330 Log
Cisco XRd status
SEC-3.1: Authentication
526e6ceb Log
Juniper ncPTX status
SEC-3.1: Authentication
a6003064 Log
Nokia SR Linux status
SEC-3.1: Authentication
ba5194b8 Log
Openconfig Lemming status
SEC-3.1: Authentication
257c5219 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
SEC-3.1: Authentication
Cisco 8808 status
SEC-3.1: Authentication
Juniper PTX10008 status
SEC-3.1: Authentication
Nokia 7250 IXR-10e status
SEC-3.1: Authentication

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Arista devices in the TLS authentication over gRPC test. It updates the metadata.textproto to include a platform exception for Arista and modifies the createNativeUser function in the Go test file to implement Arista-specific CLI configuration for user creation. I have no feedback to provide.

@singhavnish2516 singhavnish2516 self-assigned this Apr 1, 2026
@ram-mac ram-mac merged commit 557fb75 into openconfig:main Apr 1, 2026
15 of 17 checks passed
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Apr 1, 2026
* Fixing tls_authentication_over_grpc_test for Arista

* Added fix for Juniper

* added fix for juniper

* fixing go static error

* removing deviation for jun

* fixing the hostname issue

* added cleanup function to th eend

---------

Co-authored-by: Chris Morrow <chris+github@as701.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants