Fixing tls_authentication_over_grpc_test for Arista#5273
Fixing tls_authentication_over_grpc_test for Arista#5273ram-mac merged 8 commits intoopenconfig:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for Arista devices within the TLS authentication over gRPC test suite. It modifies the user creation logic to utilize native EOS CLI commands, ensuring that users are correctly provisioned with the necessary privileges and roles required for gNMI configuration operations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5273 / cbb7193Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request adds support for Arista devices in the TLS authentication over gRPC test. It updates the metadata.textproto to include a platform exception for Arista and modifies the createNativeUser function in the Go test file to implement Arista-specific CLI configuration for user creation. I have no feedback to provide.
...ecurity/aaa/kne_tests/tls_authentication_over_grpc_test/tls_authentication_over_grpc_test.go
Show resolved
Hide resolved
...ecurity/aaa/kne_tests/tls_authentication_over_grpc_test/tls_authentication_over_grpc_test.go
Show resolved
Hide resolved
...ecurity/aaa/kne_tests/tls_authentication_over_grpc_test/tls_authentication_over_grpc_test.go
Show resolved
Hide resolved
* Fixing tls_authentication_over_grpc_test for Arista * Added fix for Juniper * added fix for juniper * fixing go static error * removing deviation for jun * fixing the hostname issue * added cleanup function to th eend --------- Co-authored-by: Chris Morrow <chris+github@as701.net>
Following changes were done for Arista, Juniper and Cisco
1.Arista-specific user creation in the createNativeUser function. It now uses a native EOS CLI command to create the user with privilege 15 and the network-admin role, which is required for gNMI configuration operations.
2.Juniper specifc user creation was added to the function as it is required. Otherwise the SSH authentication would fail. However, juniper still fails for metadata authentication. It will be fixed in another PR.
3.Cleanup the test after the run is over. After changing the hostname via gnmi.set, the test was not reverted back to original form. So added a defer function
4.Cisco does not support the gnmi.replace for system/hostname, so have added the code to handle the defer function accordingly.