feat(data): add friendly names to gsp geometries)#93
Open
peterdudfield wants to merge 1 commit intomainfrom
Open
feat(data): add friendly names to gsp geometries)#93peterdudfield wants to merge 1 commit intomainfrom
peterdudfield wants to merge 1 commit intomainfrom
Conversation
Benchmark ResultsBenchmark resultsBenchmark vs base branch |
Contributor
|
To be honest, I think I'll probably move all of this stuff (including the original uk_gsps) out of a SQL file and into a CSV or parquet in the client repo. This can then be applied with a simple python script calling the API (that way it's agnostic to database changes and only affected by breaking changes to the API contract). It doesn't really make sense to bundle any of it with the data platform, as it isn't part of the migrations (and that way I can add the UKPN stuff to it as well). So I'll take these names you've defined here and put them in to that set of data. |
Contributor
Author
|
That make sense, free free to close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Checklist
make lintwith your changes locally?make testwith your changes locally?Warning
PRs may be closed if all the above boxes are not checked.
Changes in this Pull Request
Add some sql to add full GSP names