Validate and reset corrupted table filter states#1418
Merged
Conversation
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Investigating people complaining develop.opencast.org being broken, it
seems like there was a change to the filters which cannot handle the
previous data which might still be stored in browsers. Like here means,
it completely crashes the interface and users just see a blank page.
The error they get is:
```
Uncaught TypeError: t.find is not a function
fk tableFilterSelectors.ts:23
D reselect.mjs:647
i reselect.mjs:584
P reselect.mjs:659
i reselect.mjs:584
u TableFilters.tsx:55
<anonymous> Redux
L use-sync-external-store-with-selector.production.js:40
h use-sync-external-store-with-selector.production.js:63
React 2
useSyncExternalStoreWithSelector use-sync-external-store-with-selector.production.js:74
n Redux
qc TableFilters.tsx:55
React 14
K scheduler.production.js:152
tableFilterSelectors.ts:23:32
```
This patch introduces a general validation for filters, resetting them
if they are corrupted in the sense that the data structure is not
correct.
This closes opencast#1381
This closes opencast#1395
47820cb to
9c6dac0
Compare
This was referenced Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating people complaining develop.opencast.org being broken, it seems like there was a change to the filters which cannot handle the previous data which might still be stored in browsers. Like here means, it completely crashes the interface and users just see a blank page.
The error they get is:
This patch introduces a general validation for filters, resetting them if they are corrupted in the sense that the data structure is not correct.
This closes #1381
This closes #1395