Testing: Safari & IE8

[krusynth]

For Safari and IE8 only, my unit tests are throwing an error complaining about the "after each" hook, which is showing up in legacy_ranges_spec.js on line 575 - this maps to backbone-events-standalone.js line 127, the _.keys call is undefined. I'm assuming this is because there's an underscore dependency that's not being resolved - but it's strange that only these two browsers are complaining. I'm digging in a bit more.

[aron]

@krues8dr the standalone lib doesn't use underscore, and it looks like it doesn't support IE8 due to Object.keys. See: https://github.com/n1k0/backbone-events-standalone/blob/master/backbone-events-standalone.js#L34

Although it looks like other ES5 methods are shimmed, so if it's just Object.keys that was an oversight they might accept a patch.

[aron]

Looks like there was even a patch offered by the author of a similar library eventify. n1k0/backbone-events-standalone#6. Perhaps we could use that.

[krusynth]

That did the trick, this is just pending acceptance of that PR.

[krusynth]

Ok, further issues that are probably somewhat related. Now there's a failure at Adder plugin "before each" hook : Object expected, which refers to this block.

[aron]

Anything more specific? A line number or a stack trace? Otherwise best thing to do is remove all the lines and add them back until it throws…

[krusynth]

It's throwing neither - and stepping through in the debugger has so many issues that it's taking forever to get to something meaningful. Doing the latter now.

[krusynth]

Appears to be core = new Annotator.Delegator(el: h.fix())

[krusynth]

Ah, Annotator.Delegator is undefined.

[krusynth]

Ah, it's undefined in every browser now. I clearly have broken something else.

Edit: fixing that in Chrome hasn't fixed it in IE still. Something else is still going on.

[tilgovi]

@krues8dr thanks for the reports. This is great.