Error in positioning of annotations

[richajain]

The annotations are not placed over the quotes hovered, rather they are being placed at some posiiton below the actual text. This may be caused due to the change d45a366 . I think offset() is relative to the document and position() is relative to offset. So using position() seems wrong here.
http://api.jquery.com/offset/
http://api.jquery.com/position/

[tilgovi]

It's not as simple as offset() vs position(). The former is correct under the assumption that the wrapper is the offset parent of the annotation. The latter is correct under the assumption that the offset parent of the annotation is positioned at (0, 0).

In many uses of Annotator, both of these are true. When the body, or some other parent of the wrapper div, is not at (0, 0), the current version breaks. The old version worked. This is a proper regression.

However, in hypothesis/h, we don't use the wrapper div because I find it to be nasty and unnecessary to manipulate the DOM that way. That was what motivated the change.

Here's a plunk which demonstrates: http://plnkr.co/edit/FVmBmchrO3zmcYTTDtTJ

The proper solution is to check the offset parent. If the offset parent of the target is the wrapper, then the .offset() of that should be taken. Otherwise, the .offset() of the offset parent of the wrapper should be taken as the origin point.

[tilgovi]

There's an additional issue you can see in the plunk, which I have not finished finding a solution for, which is when the target is itself the wrapper. You can see it in the plunk by clicking somewhere around the edges of the list such that the entire wrapper is highlighted in red as the target.

[tilgovi]

Plunk updated to reflect possible solution. Pull request forthcoming.