Conversation
maxj-oai
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
LOG_FORMAT=jsonandRUST_LOGare supported by app-server, but the behavior was only covered indirectly. We should verify the actual JSONL written by both user-facing entry points:codex app-serverand the standalonecodex-app-serverbinary.The existing processor shutdown message also always said the channel closed, even though the processor can exit for several different reasons. Structured fields make that event more accurate and useful to log consumers.
What changed
exit_reason, remaining connection count, and forced-shutdown state as structured tracing fields.codex app-serverandcodex-app-server, asserting the stablelevel,fields, andtargetpayload.Test plan
just test -p codex-app-server standalone_app_server_emits_json_info_eventsjust test -p codex-cli app_server_emits_json_info_events