Skip to content

Overlap executor skill reads with namespace discovery#30225

Merged
anp-oai merged 1 commit into
mainfrom
jif/overlap-skill-namespace-discovery
Jun 26, 2026
Merged

Overlap executor skill reads with namespace discovery#30225
anp-oai merged 1 commit into
mainfrom
jif/overlap-skill-namespace-discovery

Conversation

@jif-oai

@jif-oai jif-oai commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Why

Environment skill discovery needs two independent pieces of information:

  • plugin namespaces from plugin.json files; and
  • skill metadata from each SKILL.md file.

Today these happen in sequence. Codex waits for every plugin namespace lookup to finish before it starts reading any skill files. On a remote executor, that creates an avoidable network-latency barrier.

before: walk -> namespace lookups -> skill reads -> build catalog
after:  walk -> namespace lookups ─┐
             -> skill reads ───────┴-> build catalog

What changes

  • Read and parse skill files without waiting for plugin namespace discovery.
  • Resolve root and nested plugin namespaces concurrently.
  • Join both results only when constructing the final qualified skill names.
  • Keep the existing 64-skill concurrency bound, output ordering, warnings, metadata behavior, and namespace rules.

Testing

The regression test makes plugin manifest lookup wait until a SKILL.md read has started. The old serialized pipeline would time out; the new pipeline completes and still returns the correctly namespaced skill.

just test -p codex-core-skills passes all 111 tests.

Out of scope

This does not add an exec-server endpoint, batch filesystem calls, or reduce the number of files transferred. A frontmatter-only read or server-side skill catalog can remain a separate follow-up if benchmarks show that transferred bytes are the next bottleneck.

@jif-oai

jif-oai commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 8dd35bbdc2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anp-oai anp-oai force-pushed the jif/overlap-skill-namespace-discovery branch from 8dd35bb to ff6c83d Compare June 26, 2026 17:57
@anp-oai anp-oai enabled auto-merge (squash) June 26, 2026 17:57
@anp-oai anp-oai force-pushed the jif/overlap-skill-namespace-discovery branch from ff6c83d to 433c3b8 Compare June 26, 2026 18:24
@anp-oai anp-oai merged commit a938d5f into main Jun 26, 2026
31 checks passed
@anp-oai anp-oai deleted the jif/overlap-skill-namespace-discovery branch June 26, 2026 18:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants