[codex] group blocking and postmerge CI workflows#30146
Merged
Conversation
f29c64a to
aa28ffd
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d4f4b1620
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
approved these changes
Jun 26, 2026
2b961c1 to
eb158bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
It's hard to change the set of required jobs when they're managed in the GitHub UI, and when each workflow is responsible for choosing it's own scheduling it's easy to end up with skew between what we enforce on PRs vs. on main.
What
blocking-cicaller workflow, triggered by pull requests and pushes tomain, for Bazel, blob size, cargo-deny, Codespell,repo-checks, rust CI, and SDK CIalways()terminal job namedCI requiredthat fails unless every called workflow succeedspostmerge-cicaller workflow forrust-ci-fullandv8-canary, with a terminalPostmerge CI resultsjobv8_canary_changes.py; unrelated PR and postmerge runs execute metadata only and skip the expensive build matricesv8-canaryoutside the blocking gate and leave the externalclacheck independentRollout
A repository admin must replace the existing required GitHub Actions contexts with
CI requiredin the main-branch ruleset. Retainclaas a separate required check. Until that change is coordinated, this PR cannot satisfy the old standalone check names. In-flight PRs will need to be rebased after this lands.