[codex] narrow unused skills intro export#29991
Merged
Merged
Conversation
Collaborator
Author
|
@codex review this |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9afeaf458
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKILLS_INTRO_WITH_ALIASESconstantScope guardrails
This revision keeps all remote/network-facing functionality and every line introduced by
jif <jif@openai.com>.Following the test-preservation audit, it also restores the in-process RMCP test transport, the original
codex-mcpfixture,PluginLoadOutcome::effective_skill_rootsand its assertions, theEffectiveSkillRootsAPI family, the test-only apps renderer, and the TUI dead-code annotation. Those files now match the PR base exactly.No test imports or directly references the remaining public skills export being narrowed.
Validation
git blameaudit: zero Jif-authored deletionscargo test -p codex-core-plugins -p codex-mcp -p codex-rmcp-client --lib: 467 passedcargo test -p codex-core --lib apps::render: 2 passedcargo test -p codex-core-skills --lib render::tests: 19 passedcargo check -p codex-core-skills --all-targets: passedjust fix -p codex-core-skills: passedjust fmt: passedgit diff --check: passedThe full local
codex-core-skillssuite passed 106/108 tests; two loader tests detected an ambient repository skills root outside the package and failed their isolation assertions. The scoped renderer suite and all-target compile pass, and CI runs in an isolated environment.Final code delta: 1 insertion, 2 deletions across 2 files.