Skip to content

[codex] narrow unused skills intro export#29991

Merged
aibrahim-oai merged 7 commits into
mainfrom
codex/delete-dead-integration-code
Jun 26, 2026
Merged

[codex] narrow unused skills intro export#29991
aibrahim-oai merged 7 commits into
mainfrom
codex/delete-dead-integration-code

Conversation

@aibrahim-oai

@aibrahim-oai aibrahim-oai commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • stop publicly re-exporting the internally used SKILLS_INTRO_WITH_ALIASES constant
  • keep the constant and all skills rendering behavior unchanged
  • preserve every integration helper, API, fixture, assertion, and module used by tests

Scope guardrails

This revision keeps all remote/network-facing functionality and every line introduced by jif <jif@openai.com>.

Following the test-preservation audit, it also restores the in-process RMCP test transport, the original codex-mcp fixture, PluginLoadOutcome::effective_skill_roots and its assertions, the EffectiveSkillRoots API family, the test-only apps renderer, and the TUI dead-code annotation. Those files now match the PR base exactly.

No test imports or directly references the remaining public skills export being narrowed.

Validation

  • repository-wide test-reference audit: no test-used code remains deleted or narrowed
  • deleted-line git blame audit: zero Jif-authored deletions
  • cargo test -p codex-core-plugins -p codex-mcp -p codex-rmcp-client --lib: 467 passed
  • cargo test -p codex-core --lib apps::render: 2 passed
  • cargo test -p codex-core-skills --lib render::tests: 19 passed
  • cargo check -p codex-core-skills --all-targets: passed
  • just fix -p codex-core-skills: passed
  • just fmt: passed
  • git diff --check: passed

The full local codex-core-skills suite passed 106/108 tests; two loader tests detected an ambient repository skills root outside the package and failed their isolation assertions. The scoped renderer suite and all-target compile pass, and CI runs in an isolated environment.

Final code delta: 1 insertion, 2 deletions across 2 files.

@aibrahim-oai aibrahim-oai changed the title [codex] remove dead integration code [codex] remove dead local integration code Jun 25, 2026
@aibrahim-oai aibrahim-oai marked this pull request as ready for review June 25, 2026 23:21
@aibrahim-oai aibrahim-oai requested a review from a team as a code owner June 25, 2026 23:21
@aibrahim-oai

Copy link
Copy Markdown
Collaborator Author

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9afeaf458

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/rmcp-client/src/in_process_transport.rs
@aibrahim-oai aibrahim-oai changed the title [codex] remove dead local integration code [codex] narrow unused skills intro export Jun 26, 2026
@aibrahim-oai aibrahim-oai merged commit 914c8ee into main Jun 26, 2026
31 checks passed
@aibrahim-oai aibrahim-oai deleted the codex/delete-dead-integration-code branch June 26, 2026 12:52
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant